Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1618264

Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

Show all headers | View raw

On Thu, Apr 06, 2017 at 09:21:47PM +0300, Kirill A. Shutemov wrote:
> > Long story short, something as trivial as this helps here:
> 
> Yep. Works for me.
> 
> Reported-and-tested-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

Thanks.

Now, I'd really like to have more test coverage and be sure this
"cleanup" doesn't break anything else so Wei, please grab tip/master,
apply the oneliner from two messages ago, take Kirill's qemu cmdline
and run all fake numa scenarios you can think of to make sure your
cleanup doesn't break anything else.

Qemu can emulate real numa too, for example you can boot with:

-smp 64 \
-numa node,nodeid=0,cpus=1-8 \
-numa node,nodeid=1,cpus=9-16 \
-numa node,nodeid=2,cpus=17-24 \
-numa node,nodeid=3,cpus=25-32 \
-numa node,nodeid=4,cpus=0 \
-numa node,nodeid=4,cpus=33-39 \
-numa node,nodeid=5,cpus=40-47 \
-numa node,nodeid=6,cpus=48-55 \
-numa node,nodeid=7,cpus=56-63

after configuring the kernel accordingly.

Then, test baremetal too.

numa_emulation() should give you an idea about possible options
numa=fake takes. Documentation/x86/x86_64/boot-options.txt has some
(all?) too.

Thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [Patch V2 2/2] x86/mm/numa: remove the  numa_nodemask_from_meminfo() "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-04-06 14:50 +0200
  Re: [Patch V2 2/2] x86/mm/numa: remove the  numa_nodemask_from_meminfo() Borislav Petkov <bp@alien8.de> - 2017-04-06 17:10 +0200
    Re: [Patch V2 2/2] x86/mm/numa: remove the  numa_nodemask_from_meminfo() Borislav Petkov <bp@alien8.de> - 2017-04-06 20:10 +0200
      Re: [Patch V2 2/2] x86/mm/numa: remove the  numa_nodemask_from_meminfo() "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-04-06 20:30 +0200
        Re: [Patch V2 2/2] x86/mm/numa: remove the  numa_nodemask_from_meminfo() Borislav Petkov <bp@alien8.de> - 2017-04-06 20:50 +0200
          Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo() Wei Yang <richard.weiyang@gmail.com> - 2017-04-09 05:20 +0200
            Re: [Patch V2 2/2] x86/mm/numa: remove the  numa_nodemask_from_meminfo() Borislav Petkov <bp@alien8.de> - 2017-04-10 14:50 +0200

csiph-web