Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

From	Kalle Valo <kvalo@qca.qualcomm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe
Date	2017-04-03 15:30 +0200
Message-ID	<tsads-7pt-11@gated-at.bofh.it> (permalink)
References	<tkxAe-ys-43@gated-at.bofh.it> <ts5Qt-4uN-1@gated-at.bofh.it> <ts6CR-52F-1@gated-at.bofh.it> <ts9U6-7iF-11@gated-at.bofh.it> <tsa3M-7m2-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Johan Hovold <johan@kernel.org> writes:

> On Mon, Apr 03, 2017 at 01:02:28PM +0000, Kalle Valo wrote:
>> Kalle Valo <kvalo@codeaurora.org> writes:
>> 
>> > Johan Hovold <johan@kernel.org> writes:
>> >
>> >> On Mon, Mar 13, 2017 at 01:44:20PM +0100, Johan Hovold wrote:
>> >>> Make sure to check the number of endpoints to avoid dereferencing a
>> >>> NULL-pointer or accessing memory beyond the endpoint array should a
>> >>> malicious device lack the expected endpoints.
>> >>> 
>> >>> Fixes: 36bcce430657 ("ath9k_htc: Handle storage devices")
>> >>> Cc: Sujith Manoharan <Sujith.Manoharan@atheros.com>
>> >>> Signed-off-by: Johan Hovold <johan@kernel.org>
>> >>
>> >> Is this one still in your queue, Kalle?
>> >
>> > Yes, I'm just lacking behing:
>> >
>> > https://patchwork.kernel.org/patch/9620723/
>> 
>> Meant "lagging" of course. Mondays..
>> 
>> >> As I mentioned earlier, I should have added a
>> >>
>> >> Cc: stable <stable@vger.kernel.org>     # 2.6.39
>> >>
>> >> but left it out as I mistakingly thought the net recommendations to do
>> >> so applied also to wireless.
>> >
>> > Ok, I'll add that.
>> 
>> But is 2.6.39 really correct? Shouldn't it be 2.6.39+ so that it means
>> all versions since 2.6.39?
>
> Either way is fine, the stable maintainers apply them to all later
> versions.
>
> I notice now that adding a plus sign is more common, but it's still a
> 1:2 ratio judging from quick grep, while the stable-kernel-rules.rst
> actually uses a minus sign...

Heh, quite confusing :) I added the plus sign already to the patch in my
pending branch so unless you object I'll keep it.

-- 
Kalle Valo

Thread

Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe Johan Hovold <johan@kernel.org> - 2017-04-03 10:50 +0200
  Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe Kalle Valo <kvalo@codeaurora.org> - 2017-04-03 11:40 +0200
    Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe Kalle Valo <kvalo@qca.qualcomm.com> - 2017-04-03 15:10 +0200
      Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe Johan Hovold <johan@kernel.org> - 2017-04-03 15:20 +0200
        Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe Kalle Valo <kvalo@qca.qualcomm.com> - 2017-04-03 15:30 +0200
          Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe Johan Hovold <johan@kernel.org> - 2017-04-03 15:30 +0200

csiph-web