Re: [PATCH RFC v4 07/10] dt-bindings: net: add binding for QCA7000 UART

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH RFC v4 07/10] dt-bindings: net: add binding for QCA7000 UART
Date	2017-04-03 15:30 +0200
Message-ID	<tsadr-7pt-7@gated-at.bofh.it> (permalink)
References	<tpD2h-kn-9@gated-at.bofh.it> <tpDbX-nU-15@gated-at.bofh.it> <tpJAJ-5cS-5@gated-at.bofh.it> <tq2am-1Rr-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 28, 2017 at 06:18:03PM +0200, Stefan Wahren wrote:
> Am 27.03.2017 um 22:30 schrieb Rob Herring:
> > On Mon, Mar 27, 2017 at 8:37 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> >> This is the serdev binding for the QCA7000 UART driver (Ethernet over UART).
> >>
> >> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> >> ---
> >>
> >> According to this binding are still some questions:
> >>
> >> Where should be the optional hardware flow control defined (at master or slave side)?
> > Probably should be in the slave side. We already have uart-has-rtscts
> > and rts/cts-gpios for the UART. Those mean we have RTS/CTS, but not
> > necessarily that we want to enable them.
> >
> > In many cases, the driver may know what it needs.
> 
> Like all the other UART settings the hardware flow control can be
> configured in the QCA7000 firmware and the driver can't detect it.
> 
> Property suggestion for the slave side:
> 
> use-rtscts

Okay.

> >> Is it okay to have two bindings (qca-qca7000-spi and qca-qca7000-uart) or should they be merged?
> > Are they mutually-exclusive or both are used at the same time?
> 
> They are mutually-exclusive because they use the same pins.
> 
> >  What
> > are the dependencies between the interfaces?
> 
> Except they uses the same pins of the QCA7000, i can't see any dependency.

I think they should be a single doc.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH RFC v4 07/10] dt-bindings: net: add binding for QCA7000 UART Rob Herring <robh+dt@kernel.org> - 2017-03-27 22:40 +0200
  Re: [PATCH RFC v4 07/10] dt-bindings: net: add binding for QCA7000  UART Stefan Wahren <stefan.wahren@i2se.com> - 2017-03-28 18:30 +0200
    Re: [PATCH RFC v4 07/10] dt-bindings: net: add binding for QCA7000  UART Rob Herring <robh@kernel.org> - 2017-04-03 15:30 +0200

csiph-web