Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1614646

Re: [PATCH] staging: vt6656: Fix spaces, char limit and embedded func name in print.

Show all headers | View raw

On Sat, Apr 01, 2017 at 08:29:00PM -0700, Daniel Cashman wrote:
> From: Dan Cashman <dan.a.cashman@gmail.com>
> 
> Address errors and warning found in rf.c by checkpatch kernel style script.
> Specifically, change spaces to tabs, split function arguments across a new
> line to avoid 80 character limit, and remove use of embedded function name
> in a dev_dbg() call.

That's a lot of different things all in one patch, please break this up
into doing only one type of thing per patch.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: vt6656: Fix spaces, char limit and embedded func name in print. Daniel Cashman <dan.a.cashman@gmail.com> - 2017-04-02 05:30 +0200
  Re: [PATCH] staging: vt6656: Fix spaces, char limit and embedded  func name in print. Greg KH <gregkh@linuxfoundation.org> - 2017-04-02 08:10 +0200
    [Patch v2 0/3] staging: vt6656: Fix checkpatch style violations. Daniel Cashman <dan.a.cashman@gmail.com> - 2017-04-02 22:50 +0200
      [Patch v2 2/3] staging: vt6656: Replace embedded function name with __func__ in rf.c Daniel Cashman <dan.a.cashman@gmail.com> - 2017-04-02 22:50 +0200
        [Patch v2 3/3] staging: vt6656: Split arguments to avoid 80-char violation in rf.c Daniel Cashman <dan.a.cashman@gmail.com> - 2017-04-02 22:50 +0200
      [Patch v2 1/3] staging: vt6656: convert spaces to tabs for rf.c Daniel Cashman <dan.a.cashman@gmail.com> - 2017-04-02 22:50 +0200

csiph-web