Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1614645
| From | Andi Shyti <andi.shyti@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 1/2] extcon: max77843: improve the code and minimize duplicated lines |
| Date | 2017-04-02 07:40 +0200 |
| Message-ID | <trGp3-4Fr-7@gated-at.bofh.it> (permalink) |
| References | <trGp3-4Fr-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Andi Shyti <andi.shyti@samsung.com>
Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
---
drivers/extcon/extcon-max77843.c | 33 ++++++++-------------------------
1 file changed, 8 insertions(+), 25 deletions(-)
diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
index 6e722d552cf1..fcdabc4b4025 100644
--- a/drivers/extcon/extcon-max77843.c
+++ b/drivers/extcon/extcon-max77843.c
@@ -264,37 +264,20 @@ static int max77843_muic_get_cable_type(struct max77843_muic_info *info,
chg_type = info->status[MAX77843_MUIC_STATUS2] &
MAX77843_MUIC_STATUS2_CHGTYP_MASK;
- /* Check GROUND accessory with charger cable */
- if (adc == MAX77843_MUIC_ADC_GROUND) {
- if (chg_type == MAX77843_MUIC_CHG_NONE) {
- /*
- * The following state when charger cable is
- * disconnected but the GROUND accessory still
- * connected.
- */
- *attached = false;
- cable_type = info->prev_chg_type;
- info->prev_chg_type = MAX77843_MUIC_CHG_NONE;
- } else {
-
- /*
- * The following state when charger cable is
- * connected on the GROUND accessory.
- */
- *attached = true;
- cable_type = MAX77843_MUIC_CHG_GND;
- info->prev_chg_type = MAX77843_MUIC_CHG_GND;
- }
- break;
- }
-
if (chg_type == MAX77843_MUIC_CHG_NONE) {
*attached = false;
cable_type = info->prev_chg_type;
info->prev_chg_type = MAX77843_MUIC_CHG_NONE;
} else {
*attached = true;
- cable_type = info->prev_chg_type = chg_type;
+ switch (adc) {
+ case MAX77843_MUIC_ADC_GROUND:
+ info->prev_chg_type = MAX77843_MUIC_CHG_GND;
+ break;
+ default:
+ info->prev_chg_type = chg_type;
+ }
+ cable_type = info->prev_chg_type;
}
break;
case MAX77843_CABLE_GROUP_ADC_GND:
--
2.11.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/2] Add support for USB accessories in the max77843 extcon Andi Shyti <andi.shyti@gmail.com> - 2017-04-02 07:40 +0200
[PATCH v2 1/2] extcon: max77843: improve the code and minimize duplicated lines Andi Shyti <andi.shyti@gmail.com> - 2017-04-02 07:40 +0200
Re: [PATCH v2 1/2] extcon: max77843: improve the code and minimize duplicated lines Chanwoo Choi <cw00.choi@samsung.com> - 2017-04-03 10:00 +0200
csiph-web