Re: [PATCH net-next 7/8] vhost_net: try batch dequing from skb array

From	"Michael S. Tsirkin" <mst@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 7/8] vhost_net: try batch dequing from skb array
Date	2017-03-29 23:50 +0200
Message-ID	<tqtDA-4sl-13@gated-at.bofh.it> (permalink)
References	(2 earlier) <tnPhi-3Fu-75@gated-at.bofh.it> <to74t-bk-3@gated-at.bofh.it> <tqiyu-55o-17@gated-at.bofh.it> <tqjkR-5EX-1@gated-at.bofh.it> <tqjux-5Ii-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 29, 2017 at 06:53:27PM +0800, Jason Wang wrote:
> 
> 
> On 2017年03月29日 18:46, Pankaj Gupta wrote:
> > Hi Jason,
> > 
> > > On 2017年03月23日 13:34, Jason Wang wrote:
> > > > 
> > > > > > +{
> > > > > > +    if (rvq->rh != rvq->rt)
> > > > > > +        goto out;
> > > > > > +
> > > > > > +    rvq->rh = rvq->rt = 0;
> > > > > > +    rvq->rt = skb_array_consume_batched_bh(rvq->rx_array, rvq->rxq,
> > > > > > +                        VHOST_RX_BATCH);
> > > > > A comment explaining why is is -bh would be helpful.
> > > > Ok.
> > > > 
> > > > Thanks
> > > Rethink about this. It looks like -bh is not needed in this case since
> > > no consumer run in bh.
> > In that case do we need other variants of "ptr_ring_consume_batched_*()" functions.
> > Are we planning to use them in future?
> 
> I think we'd better keep them, since it serves as helpers. You can see that
> not all the helpers in ptr_ring has real users, but they were prepared for
> the future use.
> 
> Thanks

Makes sense for basic building blocks but I'm not sure we
need to do it for all APIs.


> > 
> > > Thanks
> > >

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH net-next 7/8] vhost_net: try batch dequing from skb array Jason Wang <jasowang@redhat.com> - 2017-03-29 12:00 +0200
  Re: [PATCH net-next 7/8] vhost_net: try batch dequing from skb  array Pankaj Gupta <pagupta@redhat.com> - 2017-03-29 12:50 +0200
    Re: [PATCH net-next 7/8] vhost_net: try batch dequing from skb array Jason Wang <jasowang@redhat.com> - 2017-03-29 13:00 +0200
      Re: [PATCH net-next 7/8] vhost_net: try batch dequing from skb array "Michael S. Tsirkin" <mst@redhat.com> - 2017-03-29 23:50 +0200

csiph-web