Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1611807
| From | Pankaj Gupta <pagupta@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next 7/8] vhost_net: try batch dequing from skb array |
| Date | 2017-03-29 12:50 +0200 |
| Message-ID | <tqjkR-5EX-1@gated-at.bofh.it> (permalink) |
| References | <tnjr3-6vs-3@gated-at.bofh.it> <tnjr4-6vs-15@gated-at.bofh.it> <tnPhi-3Fu-75@gated-at.bofh.it> <to74t-bk-3@gated-at.bofh.it> <tqiyu-55o-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Jason,
>
> On 2017年03月23日 13:34, Jason Wang wrote:
> >
> >
> >>
> >>> +{
> >>> + if (rvq->rh != rvq->rt)
> >>> + goto out;
> >>> +
> >>> + rvq->rh = rvq->rt = 0;
> >>> + rvq->rt = skb_array_consume_batched_bh(rvq->rx_array, rvq->rxq,
> >>> + VHOST_RX_BATCH);
> >> A comment explaining why is is -bh would be helpful.
> >
> > Ok.
> >
> > Thanks
>
> Rethink about this. It looks like -bh is not needed in this case since
> no consumer run in bh.
In that case do we need other variants of "ptr_ring_consume_batched_*()" functions.
Are we planning to use them in future?
>
> Thanks
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH net-next 7/8] vhost_net: try batch dequing from skb array Jason Wang <jasowang@redhat.com> - 2017-03-29 12:00 +0200
Re: [PATCH net-next 7/8] vhost_net: try batch dequing from skb array Pankaj Gupta <pagupta@redhat.com> - 2017-03-29 12:50 +0200
Re: [PATCH net-next 7/8] vhost_net: try batch dequing from skb array Jason Wang <jasowang@redhat.com> - 2017-03-29 13:00 +0200
Re: [PATCH net-next 7/8] vhost_net: try batch dequing from skb array "Michael S. Tsirkin" <mst@redhat.com> - 2017-03-29 23:50 +0200
csiph-web