Re: [PATCH] net: mvneta: set rx mode during resume if interface is running

From	Jisheng Zhang <jszhang@marvell.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: mvneta: set rx mode during resume if interface is running
Date	2017-03-28 04:40 +0200
Message-ID	<tpPd8-VD-9@gated-at.bofh.it> (permalink)
References	<tpAH7-75T-1@gated-at.bofh.it> <tpM5A-7a3-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Dear David,

On Mon, 27 Mar 2017 16:15:34 -0700 David Miller wrote:

> From: Jisheng Zhang <jszhang@marvell.com>
> Date: Mon, 27 Mar 2017 18:59:05 +0800
> 
> > I found a bug by:
> > 
> > 0. boot and start dhcp client
> > 1. echo mem > /sys/power/state
> > 2. resume back immediately
> > 3. don't touch dhcp client to renew the lease
> > 4. ping the gateway. No acks
> > 
> > Usually, after step2, the DHCP lease isn't expired, so in theory we
> > should resume all back. But in fact, it doesn't. It turns out
> > the rx mode isn't resumed correctly. This patch fixes it by adding
> > mvneta_set_rx_mode(dev) in the resume hook if interface is running.
> > 
> > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>  
> 
> This doesn't apply cleanly to the net tree, please respin.

This patch is generated against net-next, for mvneta suspend/resume support
is added into net-next recently. I did need to use the "[PATCH net-next]" for
the patch title, will take care in the future.

Sorry for confusion,
Jisheng

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: mvneta: set rx mode during resume if interface is running Jisheng Zhang <jszhang@marvell.com> - 2017-03-27 13:10 +0200
  Re: [PATCH] net: mvneta: set rx mode during resume if interface is  running David Miller <davem@davemloft.net> - 2017-03-28 01:20 +0200
    Re: [PATCH] net: mvneta: set rx mode during resume if interface is  running Jisheng Zhang <jszhang@marvell.com> - 2017-03-28 04:40 +0200

csiph-web