Re: [PATCH] net: mvneta: set rx mode during resume if interface is running

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Jisheng Zhang <jszhang@marvell.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: mvneta: set rx mode during resume if interface is running
Date	Tue, 28 Mar 2017 04:40:02 +0200
Message-ID	<tpPd8-VD-9@gated-at.bofh.it> (permalink)
References	<tpAH7-75T-1@gated-at.bofh.it> <tpM5A-7a3-3@gated-at.bofh.it>
X-Original-To	David Miller <davem@davemloft.net>
X-Mailer	Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	text/plain; charset="US-ASCII"
Content-Transfer-Encoding	7bit
X-Proofpoint-Virus-Version	vendor=fsecure engine=2.50.10432:,, definitions=2017-03-28_01:,, signatures=0
X-Proofpoint-Details	rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703280021
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	30
Organization	linux.* mail to news gateway
X-Original-Cc	<thomas.petazzoni@free-electrons.com>, <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
X-Original-Date	Tue, 28 Mar 2017 10:27:20 +0800
X-Original-Message-ID	<20170328102720.71f530f8@xhacker>
X-Original-References	<20170327105905.1404-1-jszhang@marvell.com> <20170327.161534.60442857212281980.davem@davemloft.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1610269

Show key headers only | View raw

Dear David,

On Mon, 27 Mar 2017 16:15:34 -0700 David Miller wrote:

> From: Jisheng Zhang <jszhang@marvell.com>
> Date: Mon, 27 Mar 2017 18:59:05 +0800
> 
> > I found a bug by:
> > 
> > 0. boot and start dhcp client
> > 1. echo mem > /sys/power/state
> > 2. resume back immediately
> > 3. don't touch dhcp client to renew the lease
> > 4. ping the gateway. No acks
> > 
> > Usually, after step2, the DHCP lease isn't expired, so in theory we
> > should resume all back. But in fact, it doesn't. It turns out
> > the rx mode isn't resumed correctly. This patch fixes it by adding
> > mvneta_set_rx_mode(dev) in the resume hook if interface is running.
> > 
> > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>  
> 
> This doesn't apply cleanly to the net tree, please respin.

This patch is generated against net-next, for mvneta suspend/resume support
is added into net-next recently. I did need to use the "[PATCH net-next]" for
the patch title, will take care in the future.

Sorry for confusion,
Jisheng

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: mvneta: set rx mode during resume if interface is running Jisheng Zhang <jszhang@marvell.com> - 2017-03-27 13:10 +0200
  Re: [PATCH] net: mvneta: set rx mode during resume if interface is  running David Miller <davem@davemloft.net> - 2017-03-28 01:20 +0200
    Re: [PATCH] net: mvneta: set rx mode during resume if interface is  running Jisheng Zhang <jszhang@marvell.com> - 2017-03-28 04:40 +0200

csiph-web