Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1609888

Re: [PATCH] rtc: cpcap: fix improper use of IRQ_NONE for request_threaded_irq

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Sun, Mar 26, 2017 at 08:34:23PM -0700, Tony Lindgren wrote:
> There's a funny typo where IRQ_NONE is used instead of IRQF_TRIGGER_NONE
> for request_threaded_irq(). Let's fix it before it gets copied elsewhere.
> 
> Fixes: dd3bf50b35e3 ("rtc: cpcap: new rtc driver")
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

Reviewed-By: Sebastian Reichel <sre@kernel.org>

-- Sebastian

> ---
>  drivers/rtc/rtc-cpcap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-cpcap.c b/drivers/rtc/rtc-cpcap.c
> --- a/drivers/rtc/rtc-cpcap.c
> +++ b/drivers/rtc/rtc-cpcap.c
> @@ -275,7 +275,7 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
>  
>  	rtc->alarm_irq = platform_get_irq(pdev, 0);
>  	err = devm_request_threaded_irq(dev, rtc->alarm_irq, NULL,
> -					cpcap_rtc_alarm_irq, IRQ_NONE,
> +					cpcap_rtc_alarm_irq, IRQF_TRIGGER_NONE,
>  					"rtc_alarm", rtc);
>  	if (err) {
>  		dev_err(dev, "Could not request alarm irq: %d\n", err);
> @@ -291,7 +291,7 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
>  	 */
>  	rtc->update_irq = platform_get_irq(pdev, 1);
>  	err = devm_request_threaded_irq(dev, rtc->update_irq, NULL,
> -					cpcap_rtc_update_irq, IRQ_NONE,
> +					cpcap_rtc_update_irq, IRQF_TRIGGER_NONE,
>  					"rtc_1hz", rtc);
>  	if (err) {
>  		dev_err(dev, "Could not request update irq: %d\n", err);
> -- 
> 2.12.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] rtc: cpcap: fix improper use of IRQ_NONE for request_threaded_irq Tony Lindgren <tony@atomide.com> - 2017-03-27 05:40 +0200
  Re: [PATCH] rtc: cpcap: fix improper use of IRQ_NONE for  request_threaded_irq Sebastian Reichel <sre@kernel.org> - 2017-03-27 16:30 +0200
  Re: [PATCH] rtc: cpcap: fix improper use of IRQ_NONE for  request_threaded_irq Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-04-08 16:50 +0200

csiph-web