[PATCH] mmc: core: Do not hold re-tuning during CMD6 commands

From	Chaotian Jing <chaotian.jing@mediatek.com>
Newsgroups	linux.kernel
Subject	[PATCH] mmc: core: Do not hold re-tuning during CMD6 commands
Date	2017-03-24 07:30 +0100
Message-ID	<toqTw-5Py-7@gated-at.bofh.it> (permalink)
References	<toqTw-5Py-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

this patch is refine for 'commit c6dbab9cb58f ("mmc: core: Hold re-tuning
during switch commands")'
Since it has 3 retries at max for CMD6, if the first CMD6 got CRC error,
then should do re-tune before the next CMD6 was sent.

Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
 drivers/mmc/core/mmc_ops.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
index fe80f26..6931927 100644
--- a/drivers/mmc/core/mmc_ops.c
+++ b/drivers/mmc/core/mmc_ops.c
@@ -534,8 +534,6 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
 	bool use_r1b_resp = use_busy_signal;
 	unsigned char old_timing = host->ios.timing;
 
-	mmc_retune_hold(host);
-
 	/*
 	 * If the cmd timeout and the max_busy_timeout of the host are both
 	 * specified, let's validate them. A failure means we need to prevent
@@ -567,6 +565,7 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
 		cmd.sanitize_busy = true;
 
 	err = mmc_wait_for_cmd(host, &cmd, MMC_CMD_RETRIES);
+	mmc_retune_hold(host);
 	if (err)
 		goto out;
 
-- 
1.7.9.5

Thread

mmc: core: Do not hold re-tuning during CMD6 commands Chaotian Jing <chaotian.jing@mediatek.com> - 2017-03-24 07:30 +0100
  [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Chaotian Jing <chaotian.jing@mediatek.com> - 2017-03-24 07:30 +0100
    Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Adrian Hunter <adrian.hunter@intel.com> - 2017-03-24 09:10 +0100
      Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Chaotian Jing <chaotian.jing@mediatek.com> - 2017-03-24 09:40 +0100
        Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Adrian Hunter <adrian.hunter@intel.com> - 2017-03-24 10:30 +0100
          Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Chaotian Jing <chaotian.jing@mediatek.com> - 2017-03-24 10:50 +0100
            Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Ulf Hansson <ulf.hansson@linaro.org> - 2017-03-24 12:00 +0100
              Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Chaotian Jing <chaotian.jing@mediatek.com> - 2017-03-27 03:40 +0200

csiph-web