Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1608151

[PATCH] mmc: core: Do not hold re-tuning during CMD6 commands

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Chaotian Jing <chaotian.jing@mediatek.com>
Newsgroups linux.kernel
Subject [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands
Date Fri, 24 Mar 2017 07:30:02 +0100
Message-ID <toqTw-5Py-7@gated-at.bofh.it> (permalink)
References <toqTw-5Py-5@gated-at.bofh.it>
X-Original-To Ulf Hansson <ulf.hansson@linaro.org>
X-Mailer git-send-email 1.7.9.5
MIME-Version 1.0
Content-Type text/plain
X-Mtk N
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 33
Organization linux.* mail to news gateway
X-Original-Cc Matthias Brugger <matthias.bgg@gmail.com>, Adrian Hunter <adrian.hunter@intel.com>, Jaehoon Chung <jh80.chung@samsung.com>, Chaotian Jing <chaotian.jing@mediatek.com>, Shawn Lin <shawn.lin@rock-chips.com>, Masahiro Yamada <yamada.masahiro@socionext.com>, <linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org>, <srv_heupstream@mediatek.com>
X-Original-Date Fri, 24 Mar 2017 14:19:00 +0800
X-Original-Message-ID <1490336341-22292-2-git-send-email-chaotian.jing@mediatek.com>
X-Original-References <1490336341-22292-1-git-send-email-chaotian.jing@mediatek.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1608151

Show key headers only | View raw


this patch is refine for 'commit c6dbab9cb58f ("mmc: core: Hold re-tuning
during switch commands")'
Since it has 3 retries at max for CMD6, if the first CMD6 got CRC error,
then should do re-tune before the next CMD6 was sent.

Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
 drivers/mmc/core/mmc_ops.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
index fe80f26..6931927 100644
--- a/drivers/mmc/core/mmc_ops.c
+++ b/drivers/mmc/core/mmc_ops.c
@@ -534,8 +534,6 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
 	bool use_r1b_resp = use_busy_signal;
 	unsigned char old_timing = host->ios.timing;
 
-	mmc_retune_hold(host);
-
 	/*
 	 * If the cmd timeout and the max_busy_timeout of the host are both
 	 * specified, let's validate them. A failure means we need to prevent
@@ -567,6 +565,7 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
 		cmd.sanitize_busy = true;
 
 	err = mmc_wait_for_cmd(host, &cmd, MMC_CMD_RETRIES);
+	mmc_retune_hold(host);
 	if (err)
 		goto out;
 
-- 
1.7.9.5

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

mmc: core: Do not hold re-tuning during CMD6 commands Chaotian Jing <chaotian.jing@mediatek.com> - 2017-03-24 07:30 +0100
  [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Chaotian Jing <chaotian.jing@mediatek.com> - 2017-03-24 07:30 +0100
    Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Adrian Hunter <adrian.hunter@intel.com> - 2017-03-24 09:10 +0100
      Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Chaotian Jing <chaotian.jing@mediatek.com> - 2017-03-24 09:40 +0100
        Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Adrian Hunter <adrian.hunter@intel.com> - 2017-03-24 10:30 +0100
          Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Chaotian Jing <chaotian.jing@mediatek.com> - 2017-03-24 10:50 +0100
            Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Ulf Hansson <ulf.hansson@linaro.org> - 2017-03-24 12:00 +0100
              Re: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands Chaotian Jing <chaotian.jing@mediatek.com> - 2017-03-27 03:40 +0200

csiph-web