Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1608090

Re: [PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap data structure

Show all headers | View raw

David Rientjes <rientjes@google.com> writes:

> On Mon, 20 Mar 2017, Huang, Ying wrote:
>
>> From: Huang Ying <ying.huang@intel.com>
>> 
>> Now vzalloc() is used in swap code to allocate various data
>> structures, such as swap cache, swap slots cache, cluster info, etc.
>> Because the size may be too large on some system, so that normal
>> kzalloc() may fail.  But using kzalloc() has some advantages, for
>> example, less memory fragmentation, less TLB pressure, etc.  So change
>> the data structure allocation in swap code to use kvzalloc() which
>> will try kzalloc() firstly, and fallback to vzalloc() if kzalloc()
>> failed.
>> 
>
> As questioned in -v1 of this patch, what is the benefit of directly 
> compacting and reclaiming memory for high-order pages by first preferring 
> kmalloc() if this does not require contiguous memory?

The memory allocation here is only for swap on time, not for swap out/in
time.  The performance of swap on is not considered critical.  But if
the kmalloc() is used instead of the vmalloc(), the swap out/in
performance could be improved (marginally).  More importantly, the
interference for the other activity on the system could be reduced, For
example, less memory fragmentation, less TLB usage of swap subsystem,
etc.

Best Regards,
Huang, Ying

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap data structure "Huang, Ying" <ying.huang@intel.com> - 2017-03-20 10:00 +0100
  [PATCH -v2 2/2] mm, swap: Sort swap entries before free "Huang, Ying" <ying.huang@intel.com> - 2017-03-20 10:00 +0100
  Re: [PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap  data structure David Rientjes <rientjes@google.com> - 2017-03-20 22:40 +0100
    Re: [PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap data structure "Huang\, Ying" <ying.huang@intel.com> - 2017-03-24 03:50 +0100
      Re: [PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap data  structure John Hubbard <jhubbard@nvidia.com> - 2017-03-24 05:30 +0100
        Re: [PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap data structure "Huang\, Ying" <ying.huang@intel.com> - 2017-03-24 06:00 +0100
          Re: [PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap data  structure John Hubbard <jhubbard@nvidia.com> - 2017-03-24 07:50 +0100
            Re: [PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap data structure "Huang\, Ying" <ying.huang@intel.com> - 2017-03-24 08:20 +0100
              Re: [PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap data  structure John Hubbard <jhubbard@nvidia.com> - 2017-03-24 08:40 +0100
                Re: [PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap data  structure Dave Hansen <dave.hansen@linux.intel.com> - 2017-03-24 15:00 +0100
                Re: [PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap  data structure Tim Chen <tim.c.chen@linux.intel.com> - 2017-03-24 18:00 +0100
                Re: [PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap data  structure John Hubbard <jhubbard@nvidia.com> - 2017-03-24 19:20 +0100

csiph-web