Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1604251

[PATCH -v2 2/2] mm, swap: Sort swap entries before free

Show all headers | View raw

From: Huang Ying <ying.huang@intel.com>

To reduce the lock contention of swap_info_struct->lock when freeing
swap entry.  The freed swap entries will be collected in a per-CPU
buffer firstly, and be really freed later in batch.  During the batch
freeing, if the consecutive swap entries in the per-CPU buffer belongs
to same swap device, the swap_info_struct->lock needs to be
acquired/released only once, so that the lock contention could be
reduced greatly.  But if there are multiple swap devices, it is
possible that the lock may be unnecessarily released/acquired because
the swap entries belong to the same swap device are non-consecutive in
the per-CPU buffer.

To solve the issue, the per-CPU buffer is sorted according to the swap
device before freeing the swap entries.  Test shows that the time
spent by swapcache_free_entries() could be reduced after the patch.

Test the patch via measuring the run time of swap_cache_free_entries()
during the exit phase of the applications use much swap space.  The
results shows that the average run time of swap_cache_free_entries()
reduced about 20% after applying the patch.

Signed-off-by: Huang Ying <ying.huang@intel.com>
Acked-by: Tim Chen <tim.c.chen@intel.com>
---
 mm/swapfile.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/mm/swapfile.c b/mm/swapfile.c
index 90054f3c2cdc..1628dd88da40 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -37,6 +37,7 @@
 #include <linux/swapfile.h>
 #include <linux/export.h>
 #include <linux/swap_slots.h>
+#include <linux/sort.h>
 
 #include <asm/pgtable.h>
 #include <asm/tlbflush.h>
@@ -1065,6 +1066,13 @@ void swapcache_free(swp_entry_t entry)
 	}
 }
 
+static int swp_entry_cmp(const void *ent1, const void *ent2)
+{
+	const swp_entry_t *e1 = ent1, *e2 = ent2;
+
+	return (long)(swp_type(*e1) - swp_type(*e2));
+}
+
 void swapcache_free_entries(swp_entry_t *entries, int n)
 {
 	struct swap_info_struct *p, *prev;
@@ -1075,6 +1083,7 @@ void swapcache_free_entries(swp_entry_t *entries, int n)
 
 	prev = NULL;
 	p = NULL;
+	sort(entries, n, sizeof(entries[0]), swp_entry_cmp, NULL);
 	for (i = 0; i < n; ++i) {
 		p = swap_info_get_cont(entries[i], prev);
 		if (p)
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap data structure "Huang, Ying" <ying.huang@intel.com> - 2017-03-20 10:00 +0100
  [PATCH -v2 2/2] mm, swap: Sort swap entries before free "Huang, Ying" <ying.huang@intel.com> - 2017-03-20 10:00 +0100
  Re: [PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap  data structure David Rientjes <rientjes@google.com> - 2017-03-20 22:40 +0100
    Re: [PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap data structure "Huang\, Ying" <ying.huang@intel.com> - 2017-03-24 03:50 +0100
      Re: [PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap data  structure John Hubbard <jhubbard@nvidia.com> - 2017-03-24 05:30 +0100
        Re: [PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap data structure "Huang\, Ying" <ying.huang@intel.com> - 2017-03-24 06:00 +0100
          Re: [PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap data  structure John Hubbard <jhubbard@nvidia.com> - 2017-03-24 07:50 +0100
            Re: [PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap data structure "Huang\, Ying" <ying.huang@intel.com> - 2017-03-24 08:20 +0100
              Re: [PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap data  structure John Hubbard <jhubbard@nvidia.com> - 2017-03-24 08:40 +0100
                Re: [PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap data  structure Dave Hansen <dave.hansen@linux.intel.com> - 2017-03-24 15:00 +0100
                Re: [PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap  data structure Tim Chen <tim.c.chen@linux.intel.com> - 2017-03-24 18:00 +0100
                Re: [PATCH -v2 1/2] mm, swap: Use kvzalloc to allocate some swap data  structure John Hubbard <jhubbard@nvidia.com> - 2017-03-24 19:20 +0100

csiph-web