Re: [RFC PATCH 2/4] pinctrl: rockchip: convert to raw spinlock

From	Heiko Stuebner <heiko@sntech.de>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 2/4] pinctrl: rockchip: convert to raw spinlock
Date	2017-03-15 18:20 +0100
Message-ID	<tlkKC-2iu-3@gated-at.bofh.it> (permalink)
References	<tkD2V-4vZ-3@gated-at.bofh.it> <tlkhz-1Qf-7@gated-at.bofh.it> <tlkrf-1Wi-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am Mittwoch, 15. März 2017, 16:59:00 CET schrieb John Keeping:
> On Wed, 15 Mar 2017 17:41:21 +0100, Heiko Stuebner wrote:
> > Am Mittwoch, 15. März 2017, 17:28:56 CET schrieb Heiko Stuebner:
> > > Am Montag, 13. März 2017, 18:38:11 CET schrieb John Keeping:
> > > > This lock is used from rockchip_irq_set_type() which is part of the
> > > > irq_chip implementation and thus must use raw_spinlock_t as documented
> > > > in Documentation/gpio/driver.txt.
> > > > 
> > > > Signed-off-by: John Keeping <john@metanate.com>
> > > 
> > > Looks good
> > > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> > 
> > I have to take that back.
> > This leaves the spin_lock in the schmitt trigger unconverted and produces
> > compile issues.
> > 
> > So it either needs to be converted or removed - I guess it should be
> > removed.
> Yes, it looks like it should be removed - the patches adding that hadn't
> been applied when I sent this out!
> 
> I'll rebase and add the schmitt trigger change to patch 1 in a day or
> two, after giving a bit more time for reviews.

I don't think you need to wait overly long. Linus seems happy, I'm happy and 
the schmitt issue in the open might prevent people from taking a closer look.


Heiko

Thread

Re: [RFC PATCH 2/4] pinctrl: rockchip: convert to raw spinlock Heiko Stuebner <heiko@sntech.de> - 2017-03-15 17:40 +0100
  Re: [RFC PATCH 2/4] pinctrl: rockchip: convert to raw spinlock Heiko Stuebner <heiko@sntech.de> - 2017-03-15 17:50 +0100
    Re: [RFC PATCH 2/4] pinctrl: rockchip: convert to raw spinlock John Keeping <john@metanate.com> - 2017-03-15 18:00 +0100
      Re: [RFC PATCH 2/4] pinctrl: rockchip: convert to raw spinlock Heiko Stuebner <heiko@sntech.de> - 2017-03-15 18:20 +0100
    Re: [RFC PATCH 2/4] pinctrl: rockchip: convert to raw spinlock Heiko Stuebner <heiko@sntech.de> - 2017-03-15 18:00 +0100

csiph-web