Re: [RFC PATCH 2/4] pinctrl: rockchip: convert to raw spinlock

Path	csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.roellig-ltd.de!open-news-network.org!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Heiko Stuebner <heiko@sntech.de>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 2/4] pinctrl: rockchip: convert to raw spinlock
Date	Wed, 15 Mar 2017 18:20:02 +0100
Message-ID	<tlkKC-2iu-3@gated-at.bofh.it> (permalink)
References	<tkD2V-4vZ-3@gated-at.bofh.it> <tlkhz-1Qf-7@gated-at.bofh.it> <tlkrf-1Wi-1@gated-at.bofh.it>
User-Agent	KMail/5.2.3 (Linux/4.9.0-1-amd64; KDE/5.27.0; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	8BIT
Content-Type	text/plain; charset="iso-8859-1"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	30
Organization	linux.* mail to news gateway
X-Original-Cc	linux-gpio@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org
X-Original-Date	Wed, 15 Mar 2017 18:12:53 +0100
X-Original-Message-ID	<5561804.yNijhH7yqI@phil>
X-Original-References	<20170313183813.3582-1-john@metanate.com> <2549921.4Nq1JGygY8@phil> <20170315165900.63f32371.john@metanate.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1601576

Show key headers only | View raw

Am Mittwoch, 15. März 2017, 16:59:00 CET schrieb John Keeping:
> On Wed, 15 Mar 2017 17:41:21 +0100, Heiko Stuebner wrote:
> > Am Mittwoch, 15. März 2017, 17:28:56 CET schrieb Heiko Stuebner:
> > > Am Montag, 13. März 2017, 18:38:11 CET schrieb John Keeping:
> > > > This lock is used from rockchip_irq_set_type() which is part of the
> > > > irq_chip implementation and thus must use raw_spinlock_t as documented
> > > > in Documentation/gpio/driver.txt.
> > > > 
> > > > Signed-off-by: John Keeping <john@metanate.com>
> > > 
> > > Looks good
> > > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> > 
> > I have to take that back.
> > This leaves the spin_lock in the schmitt trigger unconverted and produces
> > compile issues.
> > 
> > So it either needs to be converted or removed - I guess it should be
> > removed.
> Yes, it looks like it should be removed - the patches adding that hadn't
> been applied when I sent this out!
> 
> I'll rebase and add the schmitt trigger change to patch 1 in a day or
> two, after giving a bit more time for reviews.

I don't think you need to wait overly long. Linus seems happy, I'm happy and 
the schmitt issue in the open might prevent people from taking a closer look.


Heiko

Thread

Re: [RFC PATCH 2/4] pinctrl: rockchip: convert to raw spinlock Heiko Stuebner <heiko@sntech.de> - 2017-03-15 17:40 +0100
  Re: [RFC PATCH 2/4] pinctrl: rockchip: convert to raw spinlock Heiko Stuebner <heiko@sntech.de> - 2017-03-15 17:50 +0100
    Re: [RFC PATCH 2/4] pinctrl: rockchip: convert to raw spinlock John Keeping <john@metanate.com> - 2017-03-15 18:00 +0100
      Re: [RFC PATCH 2/4] pinctrl: rockchip: convert to raw spinlock Heiko Stuebner <heiko@sntech.de> - 2017-03-15 18:20 +0100
    Re: [RFC PATCH 2/4] pinctrl: rockchip: convert to raw spinlock Heiko Stuebner <heiko@sntech.de> - 2017-03-15 18:00 +0100

csiph-web