Re: [PATCH] staging: atomisp: clean up return logic, remove redunant code

From	Julia Lawall <julia.lawall@lip6.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: atomisp: clean up return logic, remove redunant code
Date	2017-03-12 16:10 +0100
Message-ID	<tkdia-3e0-21@gated-at.bofh.it> (permalink)
References	<tjV1U-7iY-3@gated-at.bofh.it> <tkd8u-2UH-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On Sun, 12 Mar 2017, walter harms wrote:

>
>
> Am 11.03.2017 20:32, schrieb Colin King:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > There is no need to check if ret is non-zero, remove this
> > redundant check and just return the error status from the call
> > to mt9m114_write_reg_array.
> >
> > Detected by CoverityScan, CID#1416577 ("Identical code for
> > different branches")
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> >  drivers/staging/media/atomisp/i2c/mt9m114.c | 6 +-----
> >  1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/drivers/staging/media/atomisp/i2c/mt9m114.c b/drivers/staging/media/atomisp/i2c/mt9m114.c
> > index 8762124..a555aec 100644
> > --- a/drivers/staging/media/atomisp/i2c/mt9m114.c
> > +++ b/drivers/staging/media/atomisp/i2c/mt9m114.c
> > @@ -444,12 +444,8 @@ static int mt9m114_set_suspend(struct v4l2_subdev *sd)
> >  static int mt9m114_init_common(struct v4l2_subdev *sd)
> >  {
> >  	struct i2c_client *client = v4l2_get_subdevdata(sd);
> > -	int ret;
> >
> > -	ret = mt9m114_write_reg_array(client, mt9m114_common, PRE_POLLING);
> > -	if (ret)
> > -		return ret;
> > -	return ret;
> > +	return mt9m114_write_reg_array(client, mt9m114_common, PRE_POLLING);
> >  }
>
>
> any use for "client" ?

I guess the code would be on two lines in any case.  It looks like a nice
decomposition as is.

julia

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: atomisp: clean up return logic, remove redunant code Colin King <colin.king@canonical.com> - 2017-03-11 20:40 +0100
  Re: [PATCH] staging: atomisp: clean up return logic, remove redunant  code walter harms <wharms@bfs.de> - 2017-03-12 16:00 +0100
    Re: [PATCH] staging: atomisp: clean up return logic, remove redunant  code Julia Lawall <julia.lawall@lip6.fr> - 2017-03-12 16:10 +0100

csiph-web