[PATCH] staging: atomisp: clean up return logic, remove redunant code

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] staging: atomisp: clean up return logic, remove redunant code
Date	2017-03-11 20:40 +0100
Message-ID	<tjV1U-7iY-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

There is no need to check if ret is non-zero, remove this
redundant check and just return the error status from the call
to mt9m114_write_reg_array.

Detected by CoverityScan, CID#1416577 ("Identical code for
different branches")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/staging/media/atomisp/i2c/mt9m114.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/staging/media/atomisp/i2c/mt9m114.c b/drivers/staging/media/atomisp/i2c/mt9m114.c
index 8762124..a555aec 100644
--- a/drivers/staging/media/atomisp/i2c/mt9m114.c
+++ b/drivers/staging/media/atomisp/i2c/mt9m114.c
@@ -444,12 +444,8 @@ static int mt9m114_set_suspend(struct v4l2_subdev *sd)
 static int mt9m114_init_common(struct v4l2_subdev *sd)
 {
 	struct i2c_client *client = v4l2_get_subdevdata(sd);
-	int ret;
 
-	ret = mt9m114_write_reg_array(client, mt9m114_common, PRE_POLLING);
-	if (ret)
-		return ret;
-	return ret;
+	return mt9m114_write_reg_array(client, mt9m114_common, PRE_POLLING);
 }
 
 static int power_ctrl(struct v4l2_subdev *sd, bool flag)
-- 
2.10.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: atomisp: clean up return logic, remove redunant code Colin King <colin.king@canonical.com> - 2017-03-11 20:40 +0100
  Re: [PATCH] staging: atomisp: clean up return logic, remove redunant  code walter harms <wharms@bfs.de> - 2017-03-12 16:00 +0100
    Re: [PATCH] staging: atomisp: clean up return logic, remove redunant  code Julia Lawall <julia.lawall@lip6.fr> - 2017-03-12 16:10 +0100

csiph-web