Re: [PATCH 01/10] ALSA SoC MAX98927 driver - Initial release

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/10] ALSA SoC MAX98927 driver - Initial release
Date	2017-03-12 15:20 +0100
Message-ID	<tkcvM-2Ek-1@gated-at.bofh.it> (permalink)
References	<thYdA-6Qv-9@gated-at.bofh.it> <thYdA-6Qv-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Mar 03, 2017 at 11:52:39PM +0900, Ryan Lee wrote:
> From: Ryan Lee <RyanS.Lee@maximintegrated.com>
> 
> Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com>
> ---
> 
> Initial release of ALSA SoC MAX98927 driver.
> 
>  .../devicetree/bindings/sound/max98927.txt         |   32 +

In addition to what Mark said, please split bindings to a separate 
patch.

>  sound/soc/codecs/Kconfig                           |    5 +
>  sound/soc/codecs/Makefile                          |    2 +
>  sound/soc/codecs/max98927.c                        |  954 +++++++++++++++
>  sound/soc/codecs/max98927.h                        | 1253 ++++++++++++++++++++
>  5 files changed, 2246 insertions(+)
>  create mode 100755 Documentation/devicetree/bindings/sound/max98927.txt
>  mode change 100644 => 100755 sound/soc/codecs/Kconfig
>  mode change 100644 => 100755 sound/soc/codecs/Makefile
>  create mode 100755 sound/soc/codecs/max98927.c
>  create mode 100755 sound/soc/codecs/max98927.h

These files should not be executable.

Rob

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 01/10] ALSA SoC MAX98927 driver - Initial release Rob Herring <robh@kernel.org> - 2017-03-12 15:20 +0100

csiph-web