Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1598635
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] staging: wlan-ng: fix checkpatch.pl code style warnings |
| Date | 2017-03-12 15:20 +0100 |
| Message-ID | <tkcvM-2Ek-13@gated-at.bofh.it> (permalink) |
| References | <tjWhk-88K-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Mar 11, 2017 at 10:39:56PM +0200, Andrii wrote:
> Fixed code style warnings reported by checkpatch.pl script.
What warning would that be? Please always be very specific.
>
> Signed-off-by: Andrii Vladyka <tulup@mail.ru>
Trailing whitespace on this line :(
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> index 6134eba..d7d2d13 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -1346,14 +1346,10 @@ hfa384x_docmd(struct hfa384x *hw,
> } else if (mode == DOWAIT) {
> struct usbctlx_cmd_completor completor;
>
> - result =
> - hfa384x_usbctlx_complete_sync(hw, ctlx,
> - init_cmd_completor(&completor,
> - &ctlx->
> - inbuf.
> - cmdresp,
> - &cmd->
> - result));
> + result = hfa384x_usbctlx_complete_sync(hw, ctlx,
> + init_cmd_completor(&completor,
> + &ctlx->inbuf.cmdresp,
> + &cmd->result));
It's still a pain to read, can't there be a better way to rewite the
code to be readable?
thanks,
greg k-h
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] staging: wlan-ng: fix checkpatch.pl code style warnings Andrii <tulup@mail.ru> - 2017-03-11 22:00 +0100
Re: [PATCH] staging: wlan-ng: fix checkpatch.pl code style warnings Greg KH <gregkh@linuxfoundation.org> - 2017-03-12 15:20 +0100
[PATCHv2] staging: wlan-ng: fix avoid multiple line dereference warning reported by checkpatch.pl Andrii <tulup@mail.ru> - 2017-03-12 16:40 +0100
Re: [PATCHv2] staging: wlan-ng: fix avoid multiple line dereference warning reported by checkpatch.pl Greg KH <gregkh@linuxfoundation.org> - 2017-03-12 16:50 +0100
Re: [PATCHv2] staging: wlan-ng: fix avoid multiple line dereference warning reported by checkpatch.pl Andrii <tulup@mail.ru> - 2017-03-12 17:00 +0100
Re: [PATCHv2] staging: wlan-ng: fix avoid multiple line dereference warning reported by checkpatch.pl Greg KH <gregkh@linuxfoundation.org> - 2017-03-12 17:30 +0100
csiph-web