Re: [PATCH v2 2/4] phy: exynos5: Remove duplicated defines of PHY register defines

From	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/4] phy: exynos5: Remove duplicated defines of PHY register defines
Date	2017-03-14 15:40 +0100
Message-ID	<tkVMe-1qV-35@gated-at.bofh.it> (permalink)
References	<tjTW9-6FK-3@gated-at.bofh.it> <tjTW9-6FK-1@gated-at.bofh.it> <tkVMe-1qV-37@gated-at.bofh.it> <tjTW9-6FK-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Saturday, March 11, 2017 08:25:32 PM Krzysztof Kozlowski wrote:
> Phy drivers access PMU region through regmap provided by exynos-pmu
> driver.   However there is no need to duplicate defines for PMU
> registers.  Instead just use whatever is defined in exynos-regs-pmu.h.
> 
> This reduces number of defines and allows removal of one header.

exynos5-pmu.h goes away in patch #4

> Suggested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

> ---
>  drivers/phy/phy-exynos-dp-video.c           |  1 +
>  drivers/phy/phy-exynos5-usbdrd.c            |  1 +
>  include/linux/mfd/syscon/exynos5-pmu.h      | 27 ---------------------------
>  include/linux/soc/samsung/exynos-regs-pmu.h |  8 ++++++++
>  4 files changed, 10 insertions(+), 27 deletions(-)

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/4] phy: exynos5: Remove duplicated defines of PHY  register defines Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-14 15:40 +0100
  Re: [PATCH v2 2/4] phy: exynos5: Remove duplicated defines of PHY  register defines Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-14 16:00 +0100

csiph-web