Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1600506 > unrolled thread

Re: [PATCH v2 2/4] phy: exynos5: Remove duplicated defines of PHY register defines

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 2/4] phy: exynos5: Remove duplicated defines of PHY  register defines Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-14 15:40 +0100
    Re: [PATCH v2 2/4] phy: exynos5: Remove duplicated defines of PHY  register defines Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-14 16:00 +0100

#1600506 — Re: [PATCH v2 2/4] phy: exynos5: Remove duplicated defines of PHY register defines

On Saturday, March 11, 2017 08:25:32 PM Krzysztof Kozlowski wrote:
> Phy drivers access PMU region through regmap provided by exynos-pmu
> driver.   However there is no need to duplicate defines for PMU
> registers.  Instead just use whatever is defined in exynos-regs-pmu.h.
> 
> This reduces number of defines and allows removal of one header.

exynos5-pmu.h goes away in patch #4

> Suggested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

> ---
>  drivers/phy/phy-exynos-dp-video.c           |  1 +
>  drivers/phy/phy-exynos5-usbdrd.c            |  1 +
>  include/linux/mfd/syscon/exynos5-pmu.h      | 27 ---------------------------
>  include/linux/soc/samsung/exynos-regs-pmu.h |  8 ++++++++
>  4 files changed, 10 insertions(+), 27 deletions(-)

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

[toc] | [next] | [standalone]

#1600523

On Tue, Mar 14, 2017 at 4:37 PM, Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
> On Saturday, March 11, 2017 08:25:32 PM Krzysztof Kozlowski wrote:
>> Phy drivers access PMU region through regmap provided by exynos-pmu
>> driver.   However there is no need to duplicate defines for PMU
>> registers.  Instead just use whatever is defined in exynos-regs-pmu.h.
>>
>> This reduces number of defines and allows removal of one header.
>
> exynos5-pmu.h goes away in patch #4

Right, I will leave only the first part about number of defines.

Thanks,
Krzysztof

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web