Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1599635

Re: [RESEND PATCH] drm/msm: adreno: fix build error without debugfs

Show all headers | View raw

On Mon, Mar 13, 2017 at 12:43 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The newly added a5xx support fails to build when debugfs is diabled:
>
> drivers/gpu/drm/msm/adreno/a5xx_gpu.c:849:4: error: 'struct msm_gpu_funcs' has no member named 'show'
> drivers/gpu/drm/msm/adreno/a5xx_gpu.c:849:11: error: 'a5xx_show' undeclared here (not in a function); did you mean 'a5xx_irq'?
>
> This adds a missing #ifdef.
>
> Fixes: b5f103ab98c7 ("drm/msm: gpu: Add A5XX target support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I thought I had picked this one up already, but I guess my brain was
playing tricks on me.. I've pushed this to msm-next for now and will
cherry-pick this over to a -fixes branch when I send fixes for 4.11..

BR,
-R


> ---
> Originally sent on Nov 30 for v4.10, but I now see this is still required
> on v4.11-rc2
> ---
>  drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
> index 4414cf73735d..f0c8bd74ca91 100644
> --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
> @@ -860,7 +860,9 @@ static const struct adreno_gpu_funcs funcs = {
>                 .idle = a5xx_idle,
>                 .irq = a5xx_irq,
>                 .destroy = a5xx_destroy,
> +#ifdef CONFIG_DEBUG_FS
>                 .show = a5xx_show,
> +#endif
>         },
>         .get_timestamp = a5xx_get_timestamp,
>  };
> --
> 2.9.0
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RESEND PATCH] drm/msm: adreno: fix build error without debugfs Arnd Bergmann <arnd@arndb.de> - 2017-03-13 17:50 +0100
  Re: [RESEND PATCH] drm/msm: adreno: fix build error without debugfs Rob Clark <robdclark@gmail.com> - 2017-03-13 18:10 +0100
    Re: [RESEND PATCH] drm/msm: adreno: fix build error without debugfs Emil Velikov <emil.l.velikov@gmail.com> - 2017-03-13 19:10 +0100
      Re: [RESEND PATCH] drm/msm: adreno: fix build error without debugfs Sean Paul <seanpaul@chromium.org> - 2017-03-13 20:50 +0100
        Re: [RESEND PATCH] drm/msm: adreno: fix build error without debugfs Daniel Vetter <daniel@ffwll.ch> - 2017-03-14 09:50 +0100

csiph-web