Re: [RESEND PATCH] drm/msm: adreno: fix build error without debugfs

From	Daniel Vetter <daniel@ffwll.ch>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH] drm/msm: adreno: fix build error without debugfs
Date	2017-03-14 09:50 +0100
Message-ID	<tkQjv-5Y2-9@gated-at.bofh.it> (permalink)
References	<tkBkt-3fs-15@gated-at.bofh.it> <tkBDQ-3Ed-15@gated-at.bofh.it> <tkCzT-4kS-5@gated-at.bofh.it> <tkE8F-5gy-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Mar 13, 2017 at 03:48:48PM -0400, Sean Paul wrote:
> On Mon, Mar 13, 2017 at 06:09:17PM +0000, Emil Velikov wrote:
> > On 13 March 2017 at 17:00, Rob Clark <robdclark@gmail.com> wrote:
> > > On Mon, Mar 13, 2017 at 12:43 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > >> The newly added a5xx support fails to build when debugfs is diabled:
> > >>
> > >> drivers/gpu/drm/msm/adreno/a5xx_gpu.c:849:4: error: 'struct msm_gpu_funcs' has no member named 'show'
> > >> drivers/gpu/drm/msm/adreno/a5xx_gpu.c:849:11: error: 'a5xx_show' undeclared here (not in a function); did you mean 'a5xx_irq'?
> > >>
> > >> This adds a missing #ifdef.
> > >>
> > >> Fixes: b5f103ab98c7 ("drm/msm: gpu: Add A5XX target support")
> > >> Cc: stable@vger.kernel.org
> > >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > >
> > > I thought I had picked this one up already, but I guess my brain was
> > > playing tricks on me.. I've pushed this to msm-next for now and will
> > > cherry-pick this over to a -fixes branch when I send fixes for 4.11..
> > >
> > Sean sent a similar patch last week. I think he picked it (alongside
> > others) in drm-misc-fixes.
> > Haven't checked though ;-)
> 
> Indeed [1]. I pushed it to drm-misc-fixes, but I don't see it there any longer.
> 
> At any rate, I'm glad we got the fix merged somewhere.

Bad me has force-rebased -fixes once because I screwed up something. Sorry
about that :(
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RESEND PATCH] drm/msm: adreno: fix build error without debugfs Arnd Bergmann <arnd@arndb.de> - 2017-03-13 17:50 +0100
  Re: [RESEND PATCH] drm/msm: adreno: fix build error without debugfs Rob Clark <robdclark@gmail.com> - 2017-03-13 18:10 +0100
    Re: [RESEND PATCH] drm/msm: adreno: fix build error without debugfs Emil Velikov <emil.l.velikov@gmail.com> - 2017-03-13 19:10 +0100
      Re: [RESEND PATCH] drm/msm: adreno: fix build error without debugfs Sean Paul <seanpaul@chromium.org> - 2017-03-13 20:50 +0100
        Re: [RESEND PATCH] drm/msm: adreno: fix build error without debugfs Daniel Vetter <daniel@ffwll.ch> - 2017-03-14 09:50 +0100

csiph-web