Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51
Date	2017-03-13 17:10 +0100
Message-ID	<tkAHM-2Z7-31@gated-at.bofh.it> (permalink)
References	(3 earlier) <tdiPE-3ak-23@gated-at.bofh.it> <tdkHN-4r9-49@gated-at.bofh.it> <tdX6q-7c9-9@gated-at.bofh.it> <tenNg-yV-15@gated-at.bofh.it> <tisY2-3CB-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 7, 2017 at 9:27 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Fri, Feb 24, 2017 at 02:01:30PM +0100, Pau Espin Pedrol wrote:
>> >> Dmitry, do we have special events for AC (un)plug? What is the best
>> >> approach in your opinion?
>> >
>> > Not route them through input as they not input events would be the best.
>> >
>> Is my patch good enough for this or would you recommend doing it another way?
>

> From input POV your patch makes sense.

Could you give your tag?

>
>>
>> > I'd look into hooking up power_supply class.
>> >
>> Whys is this necessay? All the related information required is already
>> present in my system.
>> I already have two power_supply instances:
>> * /sys/class/power_supply/AC0/ (provided by module "ac"), contains
>> property "online" which is correctly updated to 1 when AC is plugged
>> and 0 when AC is unplugged.
>> * /sys/class/power_supply/BAT0/ (provided by module "battery"),
>> contains property "status" which is correctly updated to "Charging"
>> when AC is plugged and "Discharging" when AC is unplugged.
>
> If everything is already working then it is not necessary. I was
> trying to say that if it does not quite work, then you shoudl look into
> integrating it better with power supply subsystem, instead of trying to
> shoehorn it into input.

-- 
With Best Regards,
Andy Shevchenko

Thread

Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51 Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-07 20:30 +0100
  Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-13 17:10 +0100
    Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51 Darren Hart <dvhart@infradead.org> - 2017-03-15 23:20 +0100
    Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51 Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-17 01:00 +0100

csiph-web