Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.unit0.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51
Date	Mon, 13 Mar 2017 17:10:03 +0100
Message-ID	<tkAHM-2Z7-31@gated-at.bofh.it> (permalink)
References	<t9nNU-6VN-23@gated-at.bofh.it> <tcfTQ-451-9@gated-at.bofh.it> <tdiPE-3ak-25@gated-at.bofh.it> <tdiPE-3ak-23@gated-at.bofh.it> <tdkHN-4r9-49@gated-at.bofh.it> <tdX6q-7c9-9@gated-at.bofh.it> <tenNg-yV-15@gated-at.bofh.it> <tisY2-3CB-5@gated-at.bofh.it>
X-Original-To	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=xvBI39hXoFsvnZ3ZDLQieM509ubuSsiE7J2tun5MfJk=; b=DyJHo6TMbmjbZEizVRwMccr6rfDk2/Ip5QZrrt46iSSmjgag/S3s8GlyVTf2CAyABc Sx/JuuiQwRJOS7kaUBU9EmENVjQ+4K57yc8RYKKz9Cc4nwENHLbJ59yhlW6rBbJ2BS1D O+aCt8xnVxyXcYVBT6uqe0yK7+LoqLAa7ZmNK5yxelhZo8qBlFos8QM1lfr1aDlKKvlU 6+9z/dXkjGrwOYLxcCJJBZujQogmfRdphOgBSaudacePbP2yNwn4A7E0+w0dTjIrEJWY rhef9dnmz014AtfyiFGmQ3rQsrW4/GNrEp3e/PFxPvvE8UGURuc75mkuip3kPmOjRUN3 aTmg==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xvBI39hXoFsvnZ3ZDLQieM509ubuSsiE7J2tun5MfJk=; b=jBYxwpyf8RuGXJIGrk9KX/iZqn8Uw/VBoKT5Fj+YxpdlXrjEEcDI6HLSfZOlQpAx+l S/4vWPR/p/T0/qFIqnlvjLI+p/LjPtQqehRJ68GFPxHdPmr+mvS997ioHrGPiHDn87Py MaKb40fyAx6flpaP6FQ6BPYy9phgaQKzrwRX8Wfieuq0w2HF/Mg9MaiJKz+kTfJvTYw3 783aPTVqLkkmQcZvb6LeAlNHoulEO4k9ZGopMUuXtfu00S0S4ELKQMiJZNu5Gdqb91rc WV2LnjLJ7LF2dX0+2A/l5s7mQfcPXczh1l/a5Cb5rChseNqINHnEkse1LDw81hxKX4Ab dtBQ==
X-Gm-Message-State	AMke39nJ2hvaVcKPh7/mr3aROZzOTTAcTOH5RZ2txOpczgVGfM/r+GASeh7gbD9mvb2hh0nUHHcqFUoBv8d3PQ==
X-Received	by 10.237.33.240 with SMTP id m45mr35036007qtc.246.1489421083253; Mon, 13 Mar 2017 09:04:43 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	Pau Espin Pedrol <pespin.shar@gmail.com>, Andy Shevchenko <andy@infradead.org>, Platform Driver <platform-driver-x86@vger.kernel.org>, Corentin Chary <corentin.chary@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, acpi4asus-user <acpi4asus-user@lists.sourceforge.net>, "dvhart@infradead.org" <dvhart@infradead.org>
X-Original-Date	Mon, 13 Mar 2017 18:04:42 +0200
X-Original-Message-ID	<CAHp75VeuhiRvmxhy886N746KvXQq9ye8CG70DQ7UyU8=0PW1tg@mail.gmail.com>
X-Original-References	<20170210174837.1078-1-pespin.shar@gmail.com> <CAHp75VfnbO_9gCfYJYCvnE-w=hkYORi+7pL5NpQCVf3UxTYZNw@mail.gmail.com> <CAEGpDuaw3uJoxbyOuTWyBodM-JgMd2hSqZUgg_wbyJa+9sJOjw@mail.gmail.com> <CAEGpDuZyFrN0CHy-E+FTwgSLfUKbA65ghenmq_fVK2qw1KDiPg@mail.gmail.com> <CAHp75Vem5Rxa+Ms5zop2zCHqExQfv9WPufQ6jPdCBpQQh0AN=w@mail.gmail.com> <20170223083631.GE18639@dtor-ws> <CAEGpDub7-ou3YJAOxxK-vj9RYNMp5ER752XMFVLdB8zWWisV8Q@mail.gmail.com> <20170307192701.GG13740@dtor-ws>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1599555

Show key headers only | View raw

On Tue, Mar 7, 2017 at 9:27 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Fri, Feb 24, 2017 at 02:01:30PM +0100, Pau Espin Pedrol wrote:
>> >> Dmitry, do we have special events for AC (un)plug? What is the best
>> >> approach in your opinion?
>> >
>> > Not route them through input as they not input events would be the best.
>> >
>> Is my patch good enough for this or would you recommend doing it another way?
>

> From input POV your patch makes sense.

Could you give your tag?

>
>>
>> > I'd look into hooking up power_supply class.
>> >
>> Whys is this necessay? All the related information required is already
>> present in my system.
>> I already have two power_supply instances:
>> * /sys/class/power_supply/AC0/ (provided by module "ac"), contains
>> property "online" which is correctly updated to 1 when AC is plugged
>> and 0 when AC is unplugged.
>> * /sys/class/power_supply/BAT0/ (provided by module "battery"),
>> contains property "status" which is correctly updated to "Charging"
>> when AC is plugged and "Discharging" when AC is unplugged.
>
> If everything is already working then it is not necessary. I was
> trying to say that if it does not quite work, then you shoudl look into
> integrating it better with power supply subsystem, instead of trying to
> shoehorn it into input.

-- 
With Best Regards,
Andy Shevchenko

Thread

Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51 Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-07 20:30 +0100
  Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-13 17:10 +0100
    Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51 Darren Hart <dvhart@infradead.org> - 2017-03-15 23:20 +0100
    Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51 Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-17 01:00 +0100

csiph-web