Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1598560

Re: [PATCH v3] statx: optimize copy of struct statx to userspace

From David Howells <dhowells@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH v3] statx: optimize copy of struct statx to userspace
Date 2017-03-12 10:20 +0100
Message-ID <tk7Pr-7PH-1@gated-at.bofh.it> (permalink)
References <tk5kC-64h-3@gated-at.bofh.it>
Organization Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw


Eric Biggers <ebiggers3@gmail.com> wrote:

> +static int cp_statx(const struct kstat *stat, struct statx __user *buffer)
> ...
> +	struct statx tmp;

This function needs to be "noinline" as tmp is big.

> -	return statx_set_result(&stat, buffer);
> +
> +	return cp_statx(&stat, buffer);

Can you leave it as statx_set_result rather than renaming it to cp_statx?

David

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3] statx: optimize copy of struct statx to userspace Eric Biggers <ebiggers3@gmail.com> - 2017-03-12 07:40 +0100
  Re: [PATCH v3] statx: optimize copy of struct statx to userspace David Howells <dhowells@redhat.com> - 2017-03-12 10:20 +0100
    Re: [PATCH v3] statx: optimize copy of struct statx to userspace Eric Biggers <ebiggers3@gmail.com> - 2017-03-13 02:10 +0100

csiph-web