Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1595419
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: RFC: SysRq nice-all-RT-tasks is broken |
| Date | 2017-03-08 19:00 +0100 |
| Message-ID | <tiO2t-1rn-3@gated-at.bofh.it> (permalink) |
| References | <tiLHk-8qM-21@gated-at.bofh.it> <tiN6p-Q0-5@gated-at.bofh.it> <tiN6q-Q0-17@gated-at.bofh.it> <tiNSO-1nX-19@gated-at.bofh.it> <tiNSO-1nX-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 8 Mar 2017 12:40:12 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> I wonder if we should just have a special flag sent by that sysrq
> trigger. Since it is causing all tasks to go "nice" there's no need to
> do the pi chain walk in __sched_setscheduler().
Hah, there already is a flag!
Laurent, can you test this patch:
-- Steve
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 3b31fc0..7292fa9 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4129,8 +4129,8 @@ static int __sched_setscheduler(struct task_struct *p,
int queue_flags = DEQUEUE_SAVE | DEQUEUE_MOVE;
struct rq *rq;
- /* May grab non-irq protected spin_locks: */
- BUG_ON(in_interrupt());
+ /* The pi code expects interrupts enabled */
+ BUG_ON(pi && in_interrupt());
recheck:
/* Double check policy once rq lock held: */
if (policy < 0) {
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
RFC: SysRq nice-all-RT-tasks is broken Laurent Dufour <ldufour@linux.vnet.ibm.com> - 2017-03-08 16:30 +0100
Re: RFC: SysRq nice-all-RT-tasks is broken Steven Rostedt <rostedt@goodmis.org> - 2017-03-08 18:00 +0100
Re: RFC: SysRq nice-all-RT-tasks is broken Steven Rostedt <rostedt@goodmis.org> - 2017-03-08 18:00 +0100
Re: RFC: SysRq nice-all-RT-tasks is broken Steven Rostedt <rostedt@goodmis.org> - 2017-03-08 18:50 +0100
Re: RFC: SysRq nice-all-RT-tasks is broken Steven Rostedt <rostedt@goodmis.org> - 2017-03-08 19:00 +0100
Re: RFC: SysRq nice-all-RT-tasks is broken Laurent Dufour <ldufour@linux.vnet.ibm.com> - 2017-03-09 12:30 +0100
Re: RFC: SysRq nice-all-RT-tasks is broken Laurent Dufour <ldufour@linux.vnet.ibm.com> - 2017-03-08 22:10 +0100
csiph-web