Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1595378
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: RFC: SysRq nice-all-RT-tasks is broken |
| Date | 2017-03-08 18:00 +0100 |
| Message-ID | <tiN6p-Q0-5@gated-at.bofh.it> (permalink) |
| References | <tiLHk-8qM-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 8 Mar 2017 16:23:35 +0100
Laurent Dufour <ldufour@linux.vnet.ibm.com> wrote:
> I got it on Power and on X86_64, but I guess it should happen in all
> architectures.
> Here are the steps to recreate it :
> 1. Create a RT task : sudo chrt -f 50 /bin/sleep 999999
> 2. On the console trigger the 'nice-all-RT-tasks' SYS-RQ.
>
> The panic is triggered by the BUG_ON(in_interrupt()) introduced by this
> commit:
>
> 66e5393a78b3 ("[PATCH] BUG() if setscheduler is called from interrupt
> context")
>
> Since SysRq is run from the interrupt context, the panic is expected.
>
> Looking at the code, I'm wondering if the BUG_ON() is still required in
> __sched_setscheduler(). But I'm not so confident, so requesting your
> advise here.
>
Hmm, that commit was added in 2.6.18, and you're right, a lot has
changed since then. Have you tried removing it and running it under
lockdep, and see if it triggers any warnings?
-- Steve
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
RFC: SysRq nice-all-RT-tasks is broken Laurent Dufour <ldufour@linux.vnet.ibm.com> - 2017-03-08 16:30 +0100
Re: RFC: SysRq nice-all-RT-tasks is broken Steven Rostedt <rostedt@goodmis.org> - 2017-03-08 18:00 +0100
Re: RFC: SysRq nice-all-RT-tasks is broken Steven Rostedt <rostedt@goodmis.org> - 2017-03-08 18:00 +0100
Re: RFC: SysRq nice-all-RT-tasks is broken Steven Rostedt <rostedt@goodmis.org> - 2017-03-08 18:50 +0100
Re: RFC: SysRq nice-all-RT-tasks is broken Steven Rostedt <rostedt@goodmis.org> - 2017-03-08 19:00 +0100
Re: RFC: SysRq nice-all-RT-tasks is broken Laurent Dufour <ldufour@linux.vnet.ibm.com> - 2017-03-09 12:30 +0100
Re: RFC: SysRq nice-all-RT-tasks is broken Laurent Dufour <ldufour@linux.vnet.ibm.com> - 2017-03-08 22:10 +0100
csiph-web