Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1592646

[PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump

From Alexey Khoroshilov <khoroshilov@ispras.ru>
Newsgroups linux.kernel
Subject [PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump
Date 2017-03-05 01:10 +0100
Message-ID <thrUl-cW-7@gated-at.bofh.it> (permalink)
References <thrUl-cW-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
 net/sched/act_skbmod.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/sched/act_skbmod.c b/net/sched/act_skbmod.c
index 3b7074e23024..c736627f8f4a 100644
--- a/net/sched/act_skbmod.c
+++ b/net/sched/act_skbmod.c
@@ -228,7 +228,6 @@ static int tcf_skbmod_dump(struct sk_buff *skb, struct tc_action *a,
 
 	return skb->len;
 nla_put_failure:
-	rcu_read_unlock();
 	nlmsg_trim(skb, b);
 	return -1;
 }
-- 
2.7.4

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump Alexey Khoroshilov <khoroshilov@ispras.ru> - 2017-03-05 01:10 +0100
  Re: [PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in  tcf_skbmod_dump Jamal Hadi Salim <jhs@mojatatu.com> - 2017-03-05 03:30 +0100
  Re: [PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock  in tcf_skbmod_dump David Miller <davem@davemloft.net> - 2017-03-07 23:50 +0100

csiph-web