[PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump

Path	csiph.com!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Alexey Khoroshilov <khoroshilov@ispras.ru>
Newsgroups	linux.kernel
Subject	[PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump
Date	Sun, 05 Mar 2017 01:10:01 +0100
Message-ID	<thrUl-cW-7@gated-at.bofh.it> (permalink)
References	<thrUl-cW-9@gated-at.bofh.it>
X-Mailer	git-send-email 2.7.4
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	21
Organization	linux.* mail to news gateway
X-Original-Cc	Alexey Khoroshilov <khoroshilov@ispras.ru>, "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
X-Original-Date	Sun, 5 Mar 2017 03:01:55 +0300
X-Original-Message-ID	<1488672115-11057-1-git-send-email-khoroshilov@ispras.ru>
X-Original-References	<f9a9b434-ea38-3f7f-6207-8c7bc7317bc4@mojatatu.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1592646

Show key headers only | View raw

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
 net/sched/act_skbmod.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/sched/act_skbmod.c b/net/sched/act_skbmod.c
index 3b7074e23024..c736627f8f4a 100644
--- a/net/sched/act_skbmod.c
+++ b/net/sched/act_skbmod.c
@@ -228,7 +228,6 @@ static int tcf_skbmod_dump(struct sk_buff *skb, struct tc_action *a,
 
 	return skb->len;
 nla_put_failure:
-	rcu_read_unlock();
 	nlmsg_trim(skb, b);
 	return -1;
 }
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump Alexey Khoroshilov <khoroshilov@ispras.ru> - 2017-03-05 01:10 +0100
  Re: [PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in  tcf_skbmod_dump Jamal Hadi Salim <jhs@mojatatu.com> - 2017-03-05 03:30 +0100
  Re: [PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock  in tcf_skbmod_dump David Miller <davem@davemloft.net> - 2017-03-07 23:50 +0100

csiph-web