Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1592455

Re: [PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings

From Russell King - ARM Linux <linux@armlinux.org.uk>
Newsgroups linux.kernel
Subject Re: [PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings
Date 2017-03-04 11:30 +0100
Message-ID <thf6O-7Dc-3@gated-at.bofh.it> (permalink)
References <theX7-7z1-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Mar 04, 2017 at 11:11:32AM +0100, Philippe Reynes wrote:
>  
>  //		lp->port = cmd->port;

Hi,

Review looks good.  However, please also update the above comment as
well.

Thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2017-03-04 11:20 +0100
  Re: [PATCH] net: smsc: smc91x: use new api  ethtool_{get|set}_link_ksettings Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-03-04 11:30 +0100
  Re: [PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings Robert Jarzmik <robert.jarzmik@free.fr> - 2017-03-04 21:30 +0100
    Re: [PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2017-03-04 23:50 +0100

csiph-web