Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1592455

Re: [PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings

Path csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!2.eu.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Russell King - ARM Linux <linux@armlinux.org.uk>
Newsgroups linux.kernel
Subject Re: [PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings
Date Sat, 04 Mar 2017 11:30:02 +0100
Message-ID <thf6O-7Dc-3@gated-at.bofh.it> (permalink)
References <theX7-7z1-1@gated-at.bofh.it>
X-Original-To Philippe Reynes <tremyfr@gmail.com>
Dkim-Signature v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2014; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=HbnEUIa7p5yfw0DzzlUwq7dzENAM8kI2TKzOw2z2l2Q=; b=kTLjOhi4s5qycrpRjFT65s+NxrYDmv09AdYzbpN/uSA3UaB918xopY1qDKZsXMFc+KqXY4xw2hMjC+2gUoWb1Kv4UCB0jj5xvM11uli8+zA5VvZD9N8Zuq0huHTEwaT3wtl3ovsofz7LwL9X1JmVTgQ+asxoKZF8hcBCQ6YS1g8=;
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.23 (2014-03-12)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 15
Organization linux.* mail to news gateway
X-Original-Cc nico@fluxnic.net, davem@davemloft.net, robert.jarzmik@free.fr, mugunthanvnm@ti.com, jarod@redhat.com, felipe.balbi@linux.intel.com, fw@strlen.de, jeremy.linton@arm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Sat, 4 Mar 2017 10:20:17 +0000
X-Original-Message-ID <20170304102017.GS21222@n2100.armlinux.org.uk>
X-Original-References <1488622292-13200-1-git-send-email-tremyfr@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1592455

Show key headers only | View raw


On Sat, Mar 04, 2017 at 11:11:32AM +0100, Philippe Reynes wrote:
>  
>  //		lp->port = cmd->port;

Hi,

Review looks good.  However, please also update the above comment as
well.

Thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2017-03-04 11:20 +0100
  Re: [PATCH] net: smsc: smc91x: use new api  ethtool_{get|set}_link_ksettings Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-03-04 11:30 +0100
  Re: [PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings Robert Jarzmik <robert.jarzmik@free.fr> - 2017-03-04 21:30 +0100
    Re: [PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2017-03-04 23:50 +0100

csiph-web