Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

From	Laura Abbott <labbott@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging
Date	2017-03-03 20:20 +0100
Message-ID	<th0Ua-5DA-15@gated-at.bofh.it> (permalink)
References	<tgGLL-8cb-5@gated-at.bofh.it> <tgSMV-8mQ-11@gated-at.bofh.it> <tgYyZ-3Rj-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 03/03/2017 08:45 AM, Laurent Pinchart wrote:
> Hi Daniel,
> 
> On Friday 03 Mar 2017 11:04:33 Daniel Vetter wrote:
>> On Thu, Mar 02, 2017 at 01:44:32PM -0800, Laura Abbott wrote:
>>> Hi,
>>>
>>> There's been some recent discussions[1] about Ion-like frameworks. There's
>>> apparently interest in just keeping Ion since it works reasonablly well.
>>> This series does what should be the final clean ups for it to possibly be
>>> moved out of staging.
>>>
>>> This includes the following:
>>> - Some general clean up and removal of features that never got a lot of
>>>   use as far as I can tell.
>>>
>>> - Fixing up the caching. This is the series I proposed back in December[2]
>>>   but never heard any feedback on. It will certainly break existing
>>>   applications that rely on the implicit caching. I'd rather make an
>>>   effort to move to a model that isn't going directly against the
>>>   establishement though.
>>>
>>> - Fixing up the platform support. The devicetree approach was never well
>>>   recieved by DT maintainers. The proposal here is to think of Ion less as
>>>   specifying requirements and more of a framework for exposing memory to
>>>   userspace.
>>>
>>> - CMA allocations now happen without the need of a dummy device structure.
>>>   This fixes a bunch of the reasons why I attempted to add devicetree
>>>   support before.
>>>
>>> I've had problems getting feedback in the past so if I don't hear any
>>> major objections I'm going to send out with the RFC dropped to be picked
>>> up. The only reason there isn't a patch to come out of staging is to
>>> discuss any other changes to the ABI people might want. Once this comes
>>> out of staging, I really don't want to mess with the ABI.
>>>
>>> Feedback appreciated.
>>
>> Imo looks all good. And I just realized that cross-checking with the TODO,
>> the 2 items about _CUSTOM and _IMPORT ioctls I noted are already there.
>>
>> Otherwise I looked through the patches, looks all really reasonable.
> 
> Two more items that need to be addressed in my opinion :
> 
> - Let's not export the ion_client API, we don't want drivers to be ion-
> specific. Only the dma-buf interface should be visible to drivers.
> 

Yes, that's a good point. I never heard back from anyone about a need for
in kernel allocation via Ion.

Thanks,
Laura

Thread

[RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
  [RFC PATCH 01/12] staging: android: ion: Remove dmap_cnt Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
  [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
    Re: [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-03-03 17:50 +0100
      Re: [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly Laura Abbott <labbott@redhat.com> - 2017-03-03 20:00 +0100
        Re: [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly Daniel Vetter <daniel@ffwll.ch> - 2017-03-06 11:50 +0100
          Re: [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-03-06 14:50 +0100
            Re: [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly Daniel Vetter <daniel@ffwll.ch> - 2017-03-06 17:00 +0100
              Re: [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly Laura Abbott <labbott@redhat.com> - 2017-03-06 20:30 +0100
  [RFC PATCH 09/12] cma: Introduce cma_for_each_area Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
  [RFC PATCH 03/12] staging: android: ion: Duplicate sg_table Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
    Re: [RFC PATCH 03/12] staging: android: ion: Duplicate sg_table "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-03-03 09:40 +0100
      Re: [RFC PATCH 03/12] staging: android: ion: Duplicate sg_table Laura Abbott <labbott@redhat.com> - 2017-03-03 19:50 +0100
  [RFC PATCH 11/12] staging: android: ion: Make Ion heaps selectable Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
    Re: [RFC PATCH 11/12] staging: android: ion: Make Ion heaps  selectable Daniel Vetter <daniel@ffwll.ch> - 2017-03-03 16:10 +0100
      Re: [RFC PATCH 11/12] staging: android: ion: Make Ion heaps  selectable Laura Abbott <labbott@redhat.com> - 2017-03-03 20:50 +0100
  [RFC PATCH 05/12] staging: android: ion: Remove page faulting support Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
  [RFC PATCH 02/12] staging: android: ion: Remove alignment from allocation field Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
  [RFC PATCH 04/12] staging: android: ion: Call dma_map_sg for syncing and mapping Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
    Re: [RFC PATCH 04/12] staging: android: ion: Call dma_map_sg for  syncing and mapping Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-03 12:10 +0100
      Re: [RFC PATCH 04/12] staging: android: ion: Call dma_map_sg for  syncing and mapping Eric Engestrom <eric.engestrom@imgtec.com> - 2017-03-03 13:00 +0100
    Re: [RFC PATCH 04/12] staging: android: ion: Call dma_map_sg for syncing and mapping Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-03-03 17:40 +0100
      Re: [RFC PATCH 04/12] staging: android: ion: Call dma_map_sg for  syncing and mapping Laura Abbott <labbott@redhat.com> - 2017-03-03 19:50 +0100
  [RFC PATCH 07/12] staging: android: ion: Remove old platform support Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
    Re: [RFC PATCH 07/12] staging: android: ion: Remove old platform  support Daniel Vetter <daniel@ffwll.ch> - 2017-03-03 11:40 +0100
  [RFC PATCH 06/12] staging: android: ion: Remove crufty cache support Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
    Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache  support Daniel Vetter <daniel@ffwll.ch> - 2017-03-03 11:00 +0100
      Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache support Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-03-03 18:00 +0100
        Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache  support Laura Abbott <labbott@redhat.com> - 2017-03-03 19:50 +0100
          Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache  support Daniel Vetter <daniel@ffwll.ch> - 2017-03-06 11:50 +0100
            Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache support Emil Velikov <emil.l.velikov@gmail.com> - 2017-03-06 18:40 +0100
              Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache  support Laura Abbott <labbott@redhat.com> - 2017-03-06 20:30 +0100
  Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Daniel Vetter <daniel@ffwll.ch> - 2017-03-03 11:40 +0100
    Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Daniel Vetter <daniel@ffwll.ch> - 2017-03-03 11:40 +0100
      Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-03-03 15:50 +0100
    Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-03-03 17:50 +0100
      Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Laura Abbott <labbott@redhat.com> - 2017-03-03 20:20 +0100
      Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Daniel Vetter <daniel@ffwll.ch> - 2017-03-06 11:50 +0100
        Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-03-06 16:10 +0100
          Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Daniel Vetter <daniel@ffwll.ch> - 2017-03-06 17:40 +0100
  Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Michal Hocko <mhocko@kernel.org> - 2017-03-03 14:40 +0100
    Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Laura Abbott <labbott@redhat.com> - 2017-03-03 18:50 +0100
      Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Michal Hocko <mhocko@kernel.org> - 2017-03-06 09:10 +0100
        Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Daniel Vetter <daniel@ffwll.ch> - 2017-03-06 12:00 +0100
          Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Mark Brown <broonie@kernel.org> - 2017-03-06 12:00 +0100
            Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Daniel Vetter <daniel@ffwll.ch> - 2017-03-06 17:20 +0100
              Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-03-09 11:10 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Laura Abbott <labbott@redhat.com> - 2017-03-09 19:10 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Brian Starkey <brian.starkey@arm.com> - 2017-03-10 11:40 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Robin Murphy <robin.murphy@arm.com> - 2017-03-10 12:50 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Brian Starkey <brian.starkey@arm.com> - 2017-03-10 15:30 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Laura Abbott <labbott@redhat.com> - 2017-03-10 17:50 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Daniel Vetter <daniel@ffwll.ch> - 2017-03-10 13:50 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Rob Clark <robdclark@gmail.com> - 2017-03-10 15:00 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-03-12 14:40 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Daniel Vetter <daniel.vetter@ffwll.ch> - 2017-03-12 20:10 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Laura Abbott <labbott@redhat.com> - 2017-03-13 22:20 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Rob Clark <robdclark@gmail.com> - 2017-03-13 22:30 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Laura Abbott <labbott@redhat.com> - 2017-03-13 23:00 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Brian Starkey <brian.starkey@arm.com> - 2017-03-13 12:00 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Mark Brown <broonie@kernel.org> - 2017-03-13 14:30 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Laura Abbott <labbott@redhat.com> - 2017-03-13 22:50 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Laura Abbott <labbott@redhat.com> - 2017-03-13 22:30 +0100
          Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Michal Hocko <mhocko@kernel.org> - 2017-03-06 14:40 +0100
  Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-03-03 17:30 +0100
    Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Laura Abbott <labbott@redhat.com> - 2017-03-03 20:20 +0100

csiph-web