Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1592251

Re: [RFC PATCH 11/12] staging: android: ion: Make Ion heaps selectable

From Laura Abbott <labbott@redhat.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH 11/12] staging: android: ion: Make Ion heaps selectable
Date 2017-03-03 20:50 +0100
Message-ID <th1nc-5Qy-9@gated-at.bofh.it> (permalink)
References <tgGLL-8cb-5@gated-at.bofh.it> <tgGLM-8cb-13@gated-at.bofh.it> <tgX0e-2X9-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 03/03/2017 02:33 AM, Daniel Vetter wrote:
> On Thu, Mar 02, 2017 at 01:44:43PM -0800, Laura Abbott wrote:
>>
>> Currently, all heaps are compiled in all the time. In switching to
>> a better platform model, let's allow these to be compiled out for good
>> measure.
>>
>> Signed-off-by: Laura Abbott <labbott@redhat.com>
> 
> I'm not the biggest fan of making everything Kconfig-selectable. And the
> #ifdef stuff doesn't look all that pretty. If we'd also use this
> opportunity to split each heap into their own file I think this patch here
> would be a lot more useful.
> 
> Anyway, no real opinion from me on this, just an idea.
> -Daniel
> 

My idea with the Kconfigs was that if platforms didn't want certain
heap types (e.g. chunk heap) they could just be turned off.
I do want to fully fix up the initialization better as well.

Thanks,
Laura

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
  [RFC PATCH 01/12] staging: android: ion: Remove dmap_cnt Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
  [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
    Re: [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-03-03 17:50 +0100
      Re: [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly Laura Abbott <labbott@redhat.com> - 2017-03-03 20:00 +0100
        Re: [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly Daniel Vetter <daniel@ffwll.ch> - 2017-03-06 11:50 +0100
          Re: [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-03-06 14:50 +0100
            Re: [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly Daniel Vetter <daniel@ffwll.ch> - 2017-03-06 17:00 +0100
              Re: [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly Laura Abbott <labbott@redhat.com> - 2017-03-06 20:30 +0100
  [RFC PATCH 09/12] cma: Introduce cma_for_each_area Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
  [RFC PATCH 03/12] staging: android: ion: Duplicate sg_table Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
    Re: [RFC PATCH 03/12] staging: android: ion: Duplicate sg_table "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-03-03 09:40 +0100
      Re: [RFC PATCH 03/12] staging: android: ion: Duplicate sg_table Laura Abbott <labbott@redhat.com> - 2017-03-03 19:50 +0100
  [RFC PATCH 11/12] staging: android: ion: Make Ion heaps selectable Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
    Re: [RFC PATCH 11/12] staging: android: ion: Make Ion heaps  selectable Daniel Vetter <daniel@ffwll.ch> - 2017-03-03 16:10 +0100
      Re: [RFC PATCH 11/12] staging: android: ion: Make Ion heaps  selectable Laura Abbott <labbott@redhat.com> - 2017-03-03 20:50 +0100
  [RFC PATCH 05/12] staging: android: ion: Remove page faulting support Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
  [RFC PATCH 02/12] staging: android: ion: Remove alignment from allocation field Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
  [RFC PATCH 04/12] staging: android: ion: Call dma_map_sg for syncing and mapping Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
    Re: [RFC PATCH 04/12] staging: android: ion: Call dma_map_sg for  syncing and mapping Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-03 12:10 +0100
      Re: [RFC PATCH 04/12] staging: android: ion: Call dma_map_sg for  syncing and mapping Eric Engestrom <eric.engestrom@imgtec.com> - 2017-03-03 13:00 +0100
    Re: [RFC PATCH 04/12] staging: android: ion: Call dma_map_sg for syncing and mapping Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-03-03 17:40 +0100
      Re: [RFC PATCH 04/12] staging: android: ion: Call dma_map_sg for  syncing and mapping Laura Abbott <labbott@redhat.com> - 2017-03-03 19:50 +0100
  [RFC PATCH 07/12] staging: android: ion: Remove old platform support Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
    Re: [RFC PATCH 07/12] staging: android: ion: Remove old platform  support Daniel Vetter <daniel@ffwll.ch> - 2017-03-03 11:40 +0100
  [RFC PATCH 06/12] staging: android: ion: Remove crufty cache support Laura Abbott <labbott@redhat.com> - 2017-03-02 22:50 +0100
    Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache  support Daniel Vetter <daniel@ffwll.ch> - 2017-03-03 11:00 +0100
      Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache support Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-03-03 18:00 +0100
        Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache  support Laura Abbott <labbott@redhat.com> - 2017-03-03 19:50 +0100
          Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache  support Daniel Vetter <daniel@ffwll.ch> - 2017-03-06 11:50 +0100
            Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache support Emil Velikov <emil.l.velikov@gmail.com> - 2017-03-06 18:40 +0100
              Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache  support Laura Abbott <labbott@redhat.com> - 2017-03-06 20:30 +0100
  Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Daniel Vetter <daniel@ffwll.ch> - 2017-03-03 11:40 +0100
    Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Daniel Vetter <daniel@ffwll.ch> - 2017-03-03 11:40 +0100
      Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-03-03 15:50 +0100
    Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-03-03 17:50 +0100
      Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Laura Abbott <labbott@redhat.com> - 2017-03-03 20:20 +0100
      Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Daniel Vetter <daniel@ffwll.ch> - 2017-03-06 11:50 +0100
        Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-03-06 16:10 +0100
          Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Daniel Vetter <daniel@ffwll.ch> - 2017-03-06 17:40 +0100
  Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Michal Hocko <mhocko@kernel.org> - 2017-03-03 14:40 +0100
    Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Laura Abbott <labbott@redhat.com> - 2017-03-03 18:50 +0100
      Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Michal Hocko <mhocko@kernel.org> - 2017-03-06 09:10 +0100
        Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Daniel Vetter <daniel@ffwll.ch> - 2017-03-06 12:00 +0100
          Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Mark Brown <broonie@kernel.org> - 2017-03-06 12:00 +0100
            Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Daniel Vetter <daniel@ffwll.ch> - 2017-03-06 17:20 +0100
              Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-03-09 11:10 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Laura Abbott <labbott@redhat.com> - 2017-03-09 19:10 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Brian Starkey <brian.starkey@arm.com> - 2017-03-10 11:40 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Robin Murphy <robin.murphy@arm.com> - 2017-03-10 12:50 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Brian Starkey <brian.starkey@arm.com> - 2017-03-10 15:30 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Laura Abbott <labbott@redhat.com> - 2017-03-10 17:50 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Daniel Vetter <daniel@ffwll.ch> - 2017-03-10 13:50 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Rob Clark <robdclark@gmail.com> - 2017-03-10 15:00 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-03-12 14:40 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Daniel Vetter <daniel.vetter@ffwll.ch> - 2017-03-12 20:10 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Laura Abbott <labbott@redhat.com> - 2017-03-13 22:20 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Rob Clark <robdclark@gmail.com> - 2017-03-13 22:30 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Laura Abbott <labbott@redhat.com> - 2017-03-13 23:00 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Brian Starkey <brian.starkey@arm.com> - 2017-03-13 12:00 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Mark Brown <broonie@kernel.org> - 2017-03-13 14:30 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Laura Abbott <labbott@redhat.com> - 2017-03-13 22:50 +0100
                Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Laura Abbott <labbott@redhat.com> - 2017-03-13 22:30 +0100
          Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Michal Hocko <mhocko@kernel.org> - 2017-03-06 14:40 +0100
  Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-03-03 17:30 +0100
    Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of  staging Laura Abbott <labbott@redhat.com> - 2017-03-03 20:20 +0100

csiph-web