Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1590260

Re: [PATCH -next] watchdog/wm831x: fix build when COMPILE_TEST is enabled

From Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Newsgroups linux.kernel
Subject Re: [PATCH -next] watchdog/wm831x: fix build when COMPILE_TEST is enabled
Date 2017-03-01 12:20 +0100
Message-ID <tgasy-2gM-11@gated-at.bofh.it> (permalink)
References <tfV0v-8jJ-41@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Feb 28, 2017 at 10:31:15AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix kconfig dependencies when COMPILE_TEST is enabled so that
> interdependent module dependencies are configured as needed.
> 
> Fixes build when WM831X_WATCHDOG=m and COMPILE_TEST=y.
> No other WM831X drivers are enabled.
> The problem is in mixing tristate and boolean dependencies.
> 
> ERROR: "wm831x_reg_write" [drivers/watchdog/wm831x_wdt.ko] undefined!
> ERROR: "wm831x_reg_read" [drivers/watchdog/wm831x_wdt.ko] undefined!
> ERROR: "wm831x_reg_unlock" [drivers/watchdog/wm831x_wdt.ko] undefined!
> ERROR: "wm831x_reg_lock" [drivers/watchdog/wm831x_wdt.ko] undefined!
> ERROR: "wm831x_set_bits" [drivers/watchdog/wm831x_wdt.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc:	patches@opensource.wolfsonmicro.com
> Cc:	Mark Brown <broonie@kernel.org>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH -next] watchdog/wm831x: fix build when COMPILE_TEST is enabled Randy Dunlap <rdunlap@infradead.org> - 2017-02-28 21:20 +0100
  Re: [PATCH -next] watchdog/wm831x: fix build when COMPILE_TEST is  enabled Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-03-01 12:20 +0100

csiph-web