[PATCH -next] watchdog/wm831x: fix build when COMPILE_TEST is enabled

From	Randy Dunlap <rdunlap@infradead.org>
Newsgroups	linux.kernel
Subject	[PATCH -next] watchdog/wm831x: fix build when COMPILE_TEST is enabled
Date	2017-02-28 21:20 +0100
Message-ID	<tfV0v-8jJ-41@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Randy Dunlap <rdunlap@infradead.org>

Fix kconfig dependencies when COMPILE_TEST is enabled so that
interdependent module dependencies are configured as needed.

Fixes build when WM831X_WATCHDOG=m and COMPILE_TEST=y.
No other WM831X drivers are enabled.
The problem is in mixing tristate and boolean dependencies.

ERROR: "wm831x_reg_write" [drivers/watchdog/wm831x_wdt.ko] undefined!
ERROR: "wm831x_reg_read" [drivers/watchdog/wm831x_wdt.ko] undefined!
ERROR: "wm831x_reg_unlock" [drivers/watchdog/wm831x_wdt.ko] undefined!
ERROR: "wm831x_reg_lock" [drivers/watchdog/wm831x_wdt.ko] undefined!
ERROR: "wm831x_set_bits" [drivers/watchdog/wm831x_wdt.ko] undefined!

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc:	patches@opensource.wolfsonmicro.com
Cc:	Mark Brown <broonie@kernel.org>
---
 drivers/watchdog/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20170228.orig/drivers/watchdog/Kconfig
+++ linux-next-20170228/drivers/watchdog/Kconfig
@@ -176,7 +176,7 @@ config WDAT_WDT
 
 config WM831X_WATCHDOG
 	tristate "WM831x watchdog"
-	depends on MFD_WM831X || COMPILE_TEST
+	depends on MFD_WM831X || (MFD_WM831X=y && COMPILE_TEST)
 	select WATCHDOG_CORE
 	help
 	  Support for the watchdog in the WM831x AudioPlus PMICs.  When

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] watchdog/wm831x: fix build when COMPILE_TEST is enabled Randy Dunlap <rdunlap@infradead.org> - 2017-02-28 21:20 +0100
  Re: [PATCH -next] watchdog/wm831x: fix build when COMPILE_TEST is  enabled Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-03-01 12:20 +0100

csiph-web