Re: [PATCH] checkpatch: don't complain on module_param(foo, bar, 0)

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] checkpatch: don't complain on module_param(foo, bar, 0)
Date	2017-02-23 23:20 +0100
Message-ID	<te9TY-7sz-37@gated-at.bofh.it> (permalink)
References	<t8KWd-7ku-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Feb 9, 2017 at 2:05 AM, Brian Norris <briannorris@chromium.org> wrote:
> The following code snippet:
>
>     module_param(writeable, bool, 0);
>
> yields this warning:
>
>     ERROR: Use 4 digit octal (0777) not decimal permissions
>     #390: FILE: drivers/mtd/spi-nor/intel-spi.c:143:
>     +module_param(writeable, bool, 0);
>     total: 1 errors, 0 warnings, 1006 lines checked
>
> But 0000 is no easier to read than 0, and module_param() even
> specifically refers to 0.

While this is all correct, the question is why we disallow to read
back on those parameters?

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] checkpatch: don't complain on module_param(foo, bar, 0) Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-23 23:20 +0100
  Re: [PATCH] checkpatch: don't complain on module_param(foo, bar, 0) Joe Perches <joe@perches.com> - 2017-02-23 23:30 +0100

csiph-web