Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1587149

Re: [PATCH] checkpatch: don't complain on module_param(foo, bar, 0)

Show all headers | View raw

On Fri, 2017-02-24 at 00:10 +0200, Andy Shevchenko wrote:
> On Thu, Feb 9, 2017 at 2:05 AM, Brian Norris <briannorris@chromium.org> wrote:
> > The following code snippet:
> > 
> >     module_param(writeable, bool, 0);
> > 
> > yields this warning:
> > 
> >     ERROR: Use 4 digit octal (0777) not decimal permissions
> >     #390: FILE: drivers/mtd/spi-nor/intel-spi.c:143:
> >     +module_param(writeable, bool, 0);
> >     total: 1 errors, 0 warnings, 1006 lines checked
> > 
> > But 0000 is no easier to read than 0, and module_param() even
> > specifically refers to 0.
> 
> While this is all correct, the question is why we disallow to read
> back on those parameters?

why disallow root to read-back any parameter?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] checkpatch: don't complain on module_param(foo, bar, 0) Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-23 23:20 +0100
  Re: [PATCH] checkpatch: don't complain on module_param(foo, bar, 0) Joe Perches <joe@perches.com> - 2017-02-23 23:30 +0100

csiph-web