Re: [PATCH v3 3/4] iio: accel: adxl345: Split driver into core and I2C

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 3/4] iio: accel: adxl345: Split driver into core and I2C
Date	2017-02-23 17:40 +0100
Message-ID	<te4AV-3Pf-9@gated-at.bofh.it> (permalink)
References	<tdClj-aH-7@gated-at.bofh.it> <tdClj-aH-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Feb 22, 2017 at 12:23 PM, Eva Rachel Retuya <eraretuya@gmail.com> wrote:
> Move I2C-specific code into its own file and rely on regmap to access
> registers. The core code provides access to x, y, z and scale readings.

Like Lars already pointed to possibility of use of this in ACPI based
platforms, I would add a reference to
commit 01427fe7c4b9 ("Input: adxl34x - make it enumerable in ACPI environment").

Please fix your patches accordingly.


> +static const struct i2c_device_id adxl345_i2c_id[] = {
> +       { "adxl345", 0 },
> +       { }
> +};
> +
> +MODULE_DEVICE_TABLE(i2c, adxl345_i2c_id);
> +
> +#ifdef CONFIG_OF
> +static const struct of_device_id adxl345_of_match[] = {
> +       { .compatible = "adi,adxl345" },
> +       { },
> +};
> +
> +MODULE_DEVICE_TABLE(of, adxl345_of_match);
> +#endif
> +
> +static struct i2c_driver adxl345_i2c_driver = {
> +       .driver = {
> +               .name   = "adxl345_i2c",
> +               .of_match_table = of_match_ptr(adxl345_of_match),
> +       },
> +       .probe          = adxl345_i2c_probe,
> +       .remove         = adxl345_i2c_remove,
> +       .id_table       = adxl345_i2c_id,
> +};
> +
> +module_i2c_driver(adxl345_i2c_driver);
> +
> +MODULE_AUTHOR("Eva Rachel Retuya <eraretuya@gmail.com>");
> +MODULE_DESCRIPTION("ADXL345 3-Axis Digital Accelerometer I2C driver");
> +MODULE_LICENSE("GPL v2");


-- 
With Best Regards,
Andy Shevchenko

Thread

[PATCH v3 3/4] iio: accel: adxl345: Split driver into core and I2C Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-22 11:30 +0100
  Re: [PATCH v3 3/4] iio: accel: adxl345: Split driver into core and I2C Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-23 17:40 +0100
    Re: [PATCH v3 3/4] iio: accel: adxl345: Split driver into core and  I2C Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-24 10:20 +0100

csiph-web