Re: [PATCH v3 2/4] iio: accel: adxl345: Use I2C regmap instead of direct I2C access

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/4] iio: accel: adxl345: Use I2C regmap instead of direct I2C access
Date	2017-02-23 17:40 +0100
Message-ID	<te4AW-3Pf-19@gated-at.bofh.it> (permalink)
References	<tdClj-aH-7@gated-at.bofh.it> <tdClk-aH-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Feb 22, 2017 at 12:22 PM, Eva Rachel Retuya <eraretuya@gmail.com> wrote:
> Convert the driver to use regmap instead of I2C-specific functions.
> Also, introduce the header file "adxl345.h" and export the probe and
> remove functions. This is done in preparation for splitting this driver
> into core and I2C-specific code as well as introduction of SPI driver.
>
> Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>

Is it possible to use device just after this very patch?
For me it seems there is bisectability issue.

> -static const struct i2c_device_id adxl345_i2c_id[] = {
> -       { "adxl345", 0 },
> -       { }
> -};
> -
> -MODULE_DEVICE_TABLE(i2c, adxl345_i2c_id);
> -
> -static struct i2c_driver adxl345_driver = {
> -       .driver = {
> -               .name   = "adxl345",
> -       },
> -       .probe          = adxl345_probe,
> -       .remove         = adxl345_remove,
> -       .id_table       = adxl345_i2c_id,
> -};
> -
> -module_i2c_driver(adxl345_driver);
> +EXPORT_SYMBOL_GPL(adxl345_common_remove);

-- 
With Best Regards,
Andy Shevchenko

Thread

[PATCH v3 0/4] iio: accel: adxl345: Split driver into core and I2C then add SPI support Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-22 11:30 +0100
  [PATCH v3 2/4] iio: accel: adxl345: Use I2C regmap instead of direct I2C access Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-22 11:30 +0100
    Re: [PATCH v3 2/4] iio: accel: adxl345: Use I2C regmap instead of  direct I2C access Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-23 17:40 +0100
      Re: [PATCH v3 2/4] iio: accel: adxl345: Use I2C regmap instead of  direct I2C access Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-24 10:10 +0100

csiph-web