Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1586032
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [Outreachy kernel] [PATCH v2 2/7] staging: most: Using macro DIV_ROUND_UP |
| Date | 2017-02-22 11:10 +0100 |
| Message-ID | <tdC1X-8u2-15@gated-at.bofh.it> (permalink) |
| References | <tdBfz-7R6-11@gated-at.bofh.it> <tdBpf-7UW-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 2017-02-22 at 10:27 +0100, Julia Lawall wrote:
> > @@ -117,7 +118,7 @@ static int alloc_dbr(u16 size)
> > return DBR_SIZE; /* out of memory */
> >
> > for (i = 0; i < DBR_MAP_SIZE; i++) {
> > - u32 const blocks = (size + DBR_BLOCK_SIZE - 1) / DBR_BLOCK_SIZE;
> > + u32 const blocks = DIV_ROUND_UP(size, DBR_BLOCK_SIZE);
> > u32 mask = ~((~(u32)0) << blocks);
>
> Totally unrelated to DIV_ROUND_UP, would this code be a candidate for
> GENMASK?
Maybe "(1 << blocks) - 1" would be more intelligible.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 2/7] staging: most: Using macro DIV_ROUND_UP simran singhal <singhalsimran0@gmail.com> - 2017-02-22 10:20 +0100
Re: [Outreachy kernel] [PATCH v2 2/7] staging: most: Using macro DIV_ROUND_UP Julia Lawall <julia.lawall@lip6.fr> - 2017-02-22 10:30 +0100
Re: [Outreachy kernel] [PATCH v2 2/7] staging: most: Using macro DIV_ROUND_UP Joe Perches <joe@perches.com> - 2017-02-22 11:10 +0100
Re: [Outreachy kernel] [PATCH v2 2/7] staging: most: Using macro DIV_ROUND_UP Julia Lawall <julia.lawall@lip6.fr> - 2017-02-22 12:40 +0100
csiph-web