Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1586033

[PATCH 0/4] perf annotate: Fixes for line numbers and Introduce source_code

Show all headers | View raw

Hi, :)

Currently perf-annotate have several problems.

  - Wrong line numbers on perf-annotate (both stdio and TUI)
  - Wrong sum of overhead(percent) matching source lines 
  - It's so confusing that the output is mixed with
    both source code and assembly code. (related to depending on 'objdump -S') 

So fix them regarding wrong line numbers
and Introduce new source_code collecting actual code,
not depending on 'objdump -S'.

In near future, I have a plan for new reable annotate view
base on source code (per function(sym)) using the 'struct source_code'. :)

I'd appreciate some feedback.

(Current v1 don't consider improvement of performance of annotate
and don't make code of annotate more compact so I'll consider them in v2) 

Thanks,
Taeung

Taeung Song (4):
  perf annotate: Remove needless regular expression for filename:linenr
  perf annotate: Align filename:linenr and more correct summary
  perf annotate: Change the method counting line numbers
  perf annotate: Introduce source_code to collect actual code

 tools/perf/util/annotate.c | 174 +++++++++++++++++++++++++++++++++++----------
 tools/perf/util/annotate.h |   7 ++
 2 files changed, 144 insertions(+), 37 deletions(-)

-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] perf annotate: Fixes for line numbers and Introduce source_code Taeung Song <treeze.taeung@gmail.com> - 2017-02-22 11:10 +0100
  [PATCH 1/4] perf annotate: Remove needless regular expression for filename:linenr Taeung Song <treeze.taeung@gmail.com> - 2017-02-22 11:10 +0100
    Re: [PATCH 1/4] perf annotate: Remove needless regular expression for filename:linenr Namhyung Kim <namhyung@kernel.org> - 2017-02-22 11:50 +0100
      Re: [PATCH 1/4] perf annotate: Remove needless regular expression for  filename:linenr Taeung Song <treeze.taeung@gmail.com> - 2017-02-22 17:20 +0100
  [PATCH 4/4] perf annotate: Introduce source_code to collect actual code Taeung Song <treeze.taeung@gmail.com> - 2017-02-22 11:10 +0100
    Re: [PATCH 4/4] perf annotate: Introduce source_code to collect  actual code Namhyung Kim <namhyung@kernel.org> - 2017-02-22 12:30 +0100
      Re: [PATCH 4/4] perf annotate: Introduce source_code to collect  actual code Taeung Song <treeze.taeung@gmail.com> - 2017-02-22 17:50 +0100
    Re: [PATCH 4/4] perf annotate: Introduce source_code to collect  actual code Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2017-02-24 07:00 +0100

csiph-web