Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1583533

[PATCH] RDMA/bnxt_re: remove redundant initialization of rc to zero

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

rc is initialized to zero but is then updated by calls to
bnxt_qplib_free_fast_reg_page_list and/or bnxt_qpliob_free_mrw
so the initialization is redundant and can be removed.

Detected with CoverityScan, CID#1408448 ("Unused Value")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/infiniband/hw/bnxt_re/ib_verbs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
index 33af2e3..17aa087 100644
--- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
+++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
@@ -2818,7 +2818,7 @@ int bnxt_re_dereg_mr(struct ib_mr *ib_mr)
 {
 	struct bnxt_re_mr *mr = container_of(ib_mr, struct bnxt_re_mr, ib_mr);
 	struct bnxt_re_dev *rdev = mr->rdev;
-	int rc = 0;
+	int rc;
 
 	if (mr->npages && mr->pages) {
 		rc = bnxt_qplib_free_fast_reg_page_list(&rdev->qplib_res,
-- 
2.10.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] RDMA/bnxt_re: remove redundant initialization of rc to zero Colin King <colin.king@canonical.com> - 2017-02-17 16:40 +0100
  Re: [PATCH] RDMA/bnxt_re: remove redundant initialization of rc to  zero Laurence Oberman <loberman@redhat.com> - 2017-02-17 17:00 +0100
  Re: [PATCH] RDMA/bnxt_re: remove redundant initialization of rc to  zero Dan Carpenter <dan.carpenter@oracle.com> - 2017-02-17 17:10 +0100

csiph-web