[PATCH] RDMA/bnxt_re: remove redundant initialization of rc to zero

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.us.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] RDMA/bnxt_re: remove redundant initialization of rc to zero
Date	Fri, 17 Feb 2017 16:40:01 +0100
Message-ID	<tbSNz-63T-7@gated-at.bofh.it> (permalink)
X-Mailer	git-send-email 2.10.2
MIME-Version	1.0
Content-Type	text/plain; charset="utf-8"
Content-Transfer-Encoding	8bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	28
Organization	linux.* mail to news gateway
X-Original-Cc	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Fri, 17 Feb 2017 15:35:22 +0000
X-Original-Message-ID	<20170217153522.30988-1-colin.king@canonical.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1583533

Show key headers only | View raw

From: Colin Ian King <colin.king@canonical.com>

rc is initialized to zero but is then updated by calls to
bnxt_qplib_free_fast_reg_page_list and/or bnxt_qpliob_free_mrw
so the initialization is redundant and can be removed.

Detected with CoverityScan, CID#1408448 ("Unused Value")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/infiniband/hw/bnxt_re/ib_verbs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
index 33af2e3..17aa087 100644
--- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
+++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
@@ -2818,7 +2818,7 @@ int bnxt_re_dereg_mr(struct ib_mr *ib_mr)
 {
 	struct bnxt_re_mr *mr = container_of(ib_mr, struct bnxt_re_mr, ib_mr);
 	struct bnxt_re_dev *rdev = mr->rdev;
-	int rc = 0;
+	int rc;
 
 	if (mr->npages && mr->pages) {
 		rc = bnxt_qplib_free_fast_reg_page_list(&rdev->qplib_res,
-- 
2.10.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] RDMA/bnxt_re: remove redundant initialization of rc to zero Colin King <colin.king@canonical.com> - 2017-02-17 16:40 +0100
  Re: [PATCH] RDMA/bnxt_re: remove redundant initialization of rc to  zero Laurence Oberman <loberman@redhat.com> - 2017-02-17 17:00 +0100
  Re: [PATCH] RDMA/bnxt_re: remove redundant initialization of rc to  zero Dan Carpenter <dan.carpenter@oracle.com> - 2017-02-17 17:10 +0100

csiph-web