Re: [PATCH] usb: musb: add code comment for clarification

From	"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: musb: add code comment for clarification
Date	2017-02-14 19:20 +0100
Message-ID	<taPRM-5dX-21@gated-at.bofh.it> (permalink)
References	<t9jAC-3XQ-27@gated-at.bofh.it> <t9jAC-3XQ-25@gated-at.bofh.it> <t9uZ3-2Mc-7@gated-at.bofh.it> <taPf3-4KR-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Quoting Greg KH <gregkh@linuxfoundation.org>:

> On Fri, Feb 10, 2017 at 06:57:41PM -0600, Gustavo A. R. Silva wrote:
>> Add code comment to make it clear that the fall-through is intentional.
>> Read the link for more details: https://lkml.org/lkml/2017/2/9/292
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> ---
>>  drivers/usb/musb/musb_core.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
>> index 892088f..1aec986 100644
>> --- a/drivers/usb/musb/musb_core.c
>> +++ b/drivers/usb/musb/musb_core.c
>> @@ -1869,6 +1869,7 @@ static void musb_pm_runtime_check_session(struct musb
>> *musb)
>>
>>                         return;
>>                 }
>> +               /* fall through */
>>         case MUSB_QUIRK_A_DISCONNECT_19:
>>                 if (musb->quirk_retries--) {
>>                         musb_dbg(musb,
>
> The tabs are all gone from this patch, and it's line-wrapped, making it
> impossible to be applied :(
>
> Can you please fix this and resend?
>

OK. I'll send it shortly.

Thanks
--
Gustavo A. R. Silva

Thread

Re: [PATCH] usb: musb: add code comment for clarification Greg KH <gregkh@linuxfoundation.org> - 2017-02-14 18:40 +0100
  Re: [PATCH] usb: musb: add code comment for clarification "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-02-14 19:20 +0100
    [PATCH v2] usb: musb: add code comment for clarification "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-02-14 19:30 +0100
      Re: [PATCH v2] usb: musb: add code comment for clarification Greg KH <gregkh@linuxfoundation.org> - 2017-02-14 19:30 +0100
        Re: [PATCH v2] usb: musb: add code comment for clarification Bin Liu <b-liu@ti.com> - 2017-02-14 20:00 +0100

csiph-web