Re: [PATCH] usb: musb: add code comment for clarification

Path	csiph.com!feeder.erje.net!1.us.feeder.erje.net!goblin1!goblin2!goblin.stu.neva.ru!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: musb: add code comment for clarification
Date	Tue, 14 Feb 2017 19:20:02 +0100
Message-ID	<taPRM-5dX-21@gated-at.bofh.it> (permalink)
References	<t9jAC-3XQ-27@gated-at.bofh.it> <t9jAC-3XQ-25@gated-at.bofh.it> <t9uZ3-2Mc-7@gated-at.bofh.it> <taPf3-4KR-5@gated-at.bofh.it>
X-Original-To	Greg KH <gregkh@linuxfoundation.org>
User-Agent	Horde Application Framework 5
Content-Type	text/plain; charset=utf-8; format=flowed; DelSp=Yes
MIME-Version	1.0
Content-Disposition	inline
X-Antiabuse	This header was added to track abuse, please include it with any abuse report
X-Antiabuse	Primary Hostname - gator4166.hostgator.com
X-Antiabuse	Original Domain - vger.kernel.org
X-Antiabuse	Originator/Caller UID/GID - [47 12] / [47 12]
X-Antiabuse	Sender Address Domain - embeddedor.com
X-Bwhitelist	no
X-Source-IP	108.167.133.22
X-Exim-ID	1cdha7-000Bwc-6Q
X-Source-Sender	gator4166.hostgator.com [108.167.133.22]:59626
X-Source-Auth	garsilva@embeddedor.com
X-Email-Count	1
X-Source-Cap	Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20=
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	Bin Liu <b-liu@ti.com>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 14 Feb 2017 12:12:02 -0600
X-Original-Message-ID	<20170214121202.Horde.qAfQoW59o5zs8CWtQR4bQyI@gator4166.hostgator.com>
X-Original-References	<20170210035654.GA11033@embeddedgus> <20170210132229.GA3446@uda0271908> <20170210185741.Horde.COi5P2LIGO-PnrSRuI3ipGV@gator4166.hostgator.com> <20170214173149.GA20378@kroah.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1580734

Show key headers only | View raw

Quoting Greg KH <gregkh@linuxfoundation.org>:

> On Fri, Feb 10, 2017 at 06:57:41PM -0600, Gustavo A. R. Silva wrote:
>> Add code comment to make it clear that the fall-through is intentional.
>> Read the link for more details: https://lkml.org/lkml/2017/2/9/292
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> ---
>>  drivers/usb/musb/musb_core.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
>> index 892088f..1aec986 100644
>> --- a/drivers/usb/musb/musb_core.c
>> +++ b/drivers/usb/musb/musb_core.c
>> @@ -1869,6 +1869,7 @@ static void musb_pm_runtime_check_session(struct musb
>> *musb)
>>
>>                         return;
>>                 }
>> +               /* fall through */
>>         case MUSB_QUIRK_A_DISCONNECT_19:
>>                 if (musb->quirk_retries--) {
>>                         musb_dbg(musb,
>
> The tabs are all gone from this patch, and it's line-wrapped, making it
> impossible to be applied :(
>
> Can you please fix this and resend?
>

OK. I'll send it shortly.

Thanks
--
Gustavo A. R. Silva

Thread

Re: [PATCH] usb: musb: add code comment for clarification Greg KH <gregkh@linuxfoundation.org> - 2017-02-14 18:40 +0100
  Re: [PATCH] usb: musb: add code comment for clarification "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-02-14 19:20 +0100
    [PATCH v2] usb: musb: add code comment for clarification "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-02-14 19:30 +0100
      Re: [PATCH v2] usb: musb: add code comment for clarification Greg KH <gregkh@linuxfoundation.org> - 2017-02-14 19:30 +0100
        Re: [PATCH v2] usb: musb: add code comment for clarification Bin Liu <b-liu@ti.com> - 2017-02-14 20:00 +0100

csiph-web