Re: [PATCH v3 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP

From	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP
Date	2017-02-14 15:40 +0100
Message-ID	<taMqR-320-9@gated-at.bofh.it> (permalink)
References	<tasit-6AY-5@gated-at.bofh.it> <tasit-6AY-3@gated-at.bofh.it> <tauki-7S8-31@gated-at.bofh.it> <taHAR-8nm-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 02/14/2017 04:20 AM, Paul Durrant wrote:
> My previous reply got bounced because my tablet insisted on using HTML...
>
>> -----Original Message-----
>>
>> These need to be static. (I can fix it when committing.)
>
> Ok, thanks.
>
>>
>> And I am still not sure about using XEN_PAGE_SIZE. There is no
>> dependency in the hypervisor on buffers being page-sized, is there? If
>> not, XEN_PAGE_SIZE is here just because it happens to be 4K, which is a
>> reasonable value.
>>
>> How about just setting it to 4096?
>>
>
> I chose XEN_PAGE_SIZE because the hypercall will eventually copy in the buffer so it seemed like a reasonable value to use. If you want to just use 4096 then I am ok with that.
>
>   Paul
>
> PS: If you want to change from XEN_PAGE_SIZE to 4096 then I assume you are happy to do this at commit and don't need me to send a v4?

Right.

But I also had a question about patch 3 (commit message). I can make the 
change when committing as well but I need to make sure you are OK with it.

-boris

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-02-13 20:20 +0100
  RE: [PATCH v3 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Paul Durrant <Paul.Durrant@citrix.com> - 2017-02-14 10:30 +0100
    Re: [PATCH v3 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-02-14 15:40 +0100

csiph-web