Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1580032 > unrolled thread

Re: [PATCH v3 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-02-13 20:20 +0100
    RE: [PATCH v3 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Paul Durrant <Paul.Durrant@citrix.com> - 2017-02-14 10:30 +0100
      Re: [PATCH v3 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-02-14 15:40 +0100

#1580032 — Re: [PATCH v3 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP

> diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
> index 5e5c7ae..a33f17e 100644
> --- a/drivers/xen/privcmd.c
> +++ b/drivers/xen/privcmd.c
> @@ -22,6 +22,7 @@
>  #include <linux/pagemap.h>
>  #include <linux/seq_file.h>
>  #include <linux/miscdevice.h>
> +#include <linux/moduleparam.h>
>
>  #include <asm/pgalloc.h>
>  #include <asm/pgtable.h>
> @@ -32,6 +33,7 @@
>  #include <xen/xen.h>
>  #include <xen/privcmd.h>
>  #include <xen/interface/xen.h>
> +#include <xen/interface/hvm/dm_op.h>
>  #include <xen/features.h>
>  #include <xen/page.h>
>  #include <xen/xen-ops.h>
> @@ -43,6 +45,17 @@ MODULE_LICENSE("GPL");
>
>  #define PRIV_VMA_LOCKED ((void *)1)
>
> +unsigned int privcmd_dm_op_max_num = 16;
> +module_param_named(dm_op_max_nr_bufs, privcmd_dm_op_max_num, uint, 0644);
> +MODULE_PARM_DESC(dm_op_max_nr_bufs,
> +		 "Maximum number of buffers per dm_op hypercall");
> +
> +unsigned int privcmd_dm_op_buf_max_size = XEN_PAGE_SIZE;

These need to be static. (I can fix it when committing.)

And I am still not sure about using XEN_PAGE_SIZE. There is no 
dependency in the hypervisor on buffers being page-sized, is there? If 
not, XEN_PAGE_SIZE is here just because it happens to be 4K, which is a 
reasonable value.

How about just setting it to 4096?


-boris

[toc] | [next] | [standalone]

#1580426

My previous reply got bounced because my tablet insisted on using HTML...

> -----Original Message-----
> 
> These need to be static. (I can fix it when committing.)

Ok, thanks.

> 
> And I am still not sure about using XEN_PAGE_SIZE. There is no
> dependency in the hypervisor on buffers being page-sized, is there? If
> not, XEN_PAGE_SIZE is here just because it happens to be 4K, which is a
> reasonable value.
> 
> How about just setting it to 4096?
> 

I chose XEN_PAGE_SIZE because the hypercall will eventually copy in the buffer so it seemed like a reasonable value to use. If you want to just use 4096 then I am ok with that.

  Paul

PS: If you want to change from XEN_PAGE_SIZE to 4096 then I assume you are happy to do this at commit and don't need me to send a v4?

> 
> -boris

[toc] | [prev] | [next] | [standalone]

#1580574

On 02/14/2017 04:20 AM, Paul Durrant wrote:
> My previous reply got bounced because my tablet insisted on using HTML...
>
>> -----Original Message-----
>>
>> These need to be static. (I can fix it when committing.)
>
> Ok, thanks.
>
>>
>> And I am still not sure about using XEN_PAGE_SIZE. There is no
>> dependency in the hypervisor on buffers being page-sized, is there? If
>> not, XEN_PAGE_SIZE is here just because it happens to be 4K, which is a
>> reasonable value.
>>
>> How about just setting it to 4096?
>>
>
> I chose XEN_PAGE_SIZE because the hypercall will eventually copy in the buffer so it seemed like a reasonable value to use. If you want to just use 4096 then I am ok with that.
>
>   Paul
>
> PS: If you want to change from XEN_PAGE_SIZE to 4096 then I assume you are happy to do this at commit and don't need me to send a v4?

Right.

But I also had a question about patch 3 (commit message). I can make the 
change when committing as well but I need to make sure you are OK with it.

-boris

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web