Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1679569

[PATCH] drm/bochs: switch fb_ops over to use drm_fb_helper_cfb helpers

Show all headers | View raw

The current drm_fb_helper_sys helpers referenced in fb_ops assume that the
video memory is in system RAM. This is not the case for sparc which uses direct
physical memory accesses for IO memory and causes the bochs_drm module to panic
immediately upon startup as it tries to initialise the framebuffer.

Switching fb_ops over to use the drm_fb_helper_cfb helpers ensures that the
correct accesses are used on sparc, fixing the panic and allowing the
bochs_drm module to function under qemu-system-sparc64.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
 drivers/gpu/drm/bochs/bochs_fbdev.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bochs/bochs_fbdev.c b/drivers/gpu/drm/bochs/bochs_fbdev.c
index 932a769..d3a75c2 100644
--- a/drivers/gpu/drm/bochs/bochs_fbdev.c
+++ b/drivers/gpu/drm/bochs/bochs_fbdev.c
@@ -23,9 +23,9 @@ static int bochsfb_mmap(struct fb_info *info,
 static struct fb_ops bochsfb_ops = {
 	.owner = THIS_MODULE,
 	DRM_FB_HELPER_DEFAULT_OPS,
-	.fb_fillrect = drm_fb_helper_sys_fillrect,
-	.fb_copyarea = drm_fb_helper_sys_copyarea,
-	.fb_imageblit = drm_fb_helper_sys_imageblit,
+	.fb_fillrect = drm_fb_helper_cfb_fillrect,
+	.fb_copyarea = drm_fb_helper_cfb_copyarea,
+	.fb_imageblit = drm_fb_helper_cfb_imageblit,
 	.fb_mmap = bochsfb_mmap,
 };
 
-- 
1.7.10.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/bochs: switch fb_ops over to use drm_fb_helper_cfb helpers Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> - 2017-07-03 00:00 +0200
  Re: [PATCH] drm/bochs: switch fb_ops over to use drm_fb_helper_cfb  helpers Daniel Vetter <daniel@ffwll.ch> - 2017-07-03 10:20 +0200
    Re: [PATCH] drm/bochs: switch fb_ops over to use drm_fb_helper_cfb  helpers Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> - 2017-07-03 10:40 +0200
      Re: [PATCH] drm/bochs: switch fb_ops over to use drm_fb_helper_cfb  helpers Gerd Hoffmann <kraxel@redhat.com> - 2017-07-03 11:00 +0200
        Re: [PATCH] drm/bochs: switch fb_ops over to use drm_fb_helper_cfb  helpers Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> - 2017-07-03 11:10 +0200

csiph-web